-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: find vaulted files automatically for config-diff
#53
Conversation
db11e1b
to
0b0e74b
Compare
One general comment, have you considered/tested how this interacts with symlinks? I'm just wondering if you could end up with duplicates in your list |
Will investigate. |
I need to check the addition of new vaulted files in the second commit as it appears |
I think this handled by https://github.com/stackhpc/kayobe-automation/blob/main/scripts/config-diff.sh#L107 |
0b0e74b
to
2d8bceb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Remove the need to manage
KAYOBE_CONFIG_VAULTED_FILES_PATHS_EXTRA
which can be annoying having to update this as new vaulted files get added.