Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: find vaulted files automatically for config-diff #53

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

jackhodgkiss
Copy link
Contributor

Remove the need to manage KAYOBE_CONFIG_VAULTED_FILES_PATHS_EXTRA which can be annoying having to update this as new vaulted files get added.

@jackhodgkiss jackhodgkiss self-assigned this Apr 11, 2024
@jackhodgkiss jackhodgkiss requested a review from a team as a code owner April 11, 2024 09:41
@jackhodgkiss jackhodgkiss force-pushed the config-diff-find-vaulted-files branch from db11e1b to 0b0e74b Compare April 11, 2024 09:44
@Alex-Welsh
Copy link
Contributor

One general comment, have you considered/tested how this interacts with symlinks? I'm just wondering if you could end up with duplicates in your list

@jackhodgkiss
Copy link
Contributor Author

jackhodgkiss commented Apr 11, 2024

One general comment, have you considered/tested how this interacts with symlinks? I'm just wondering if you could end up with duplicates in your list

Will investigate.

@jackhodgkiss
Copy link
Contributor Author

I need to check the addition of new vaulted files in the second commit as it appears main fn will check for vaulted files first then pull down the second commit.

@jackhodgkiss jackhodgkiss marked this pull request as draft April 11, 2024 10:00
@jackhodgkiss
Copy link
Contributor Author

One general comment, have you considered/tested how this interacts with symlinks? I'm just wondering if you could end up with duplicates in your list

I think this handled by redact_config_dir and encrypt_config_dir which uses realpath to expand paths and also checks for unique files.

https://github.com/stackhpc/kayobe-automation/blob/main/scripts/config-diff.sh#L107

@jackhodgkiss jackhodgkiss force-pushed the config-diff-find-vaulted-files branch from 0b0e74b to 2d8bceb Compare April 11, 2024 14:15
@jackhodgkiss jackhodgkiss marked this pull request as ready for review April 11, 2024 14:36
Copy link
Contributor

@Alex-Welsh Alex-Welsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@jovial jovial left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@jackhodgkiss jackhodgkiss merged commit a12a843 into main Apr 12, 2024
4 checks passed
@jackhodgkiss jackhodgkiss deleted the config-diff-find-vaulted-files branch April 12, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants