Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: perform config generation in parallel #55

Merged
merged 2 commits into from
Aug 16, 2024
Merged

Conversation

jackhodgkiss
Copy link
Contributor

Add support for generating configurations in parallel during config-diff.

The source config (base+PR) stdout will be displayed during the process however the target config (base only) will be sent to /dev/null.

ANSIBLE_LOG_PATH for both configurations has been set for extraction in case of error during creation. This would require change to workflows for uploading the file as an artifact.

Process appears to function as expected no noise related to fluentd templates. Maybe I am missing something in my config to encounter this issue.

The diff was non-empty. Please check the diff output.
diff -Nur /tmp/tmp.yX2Gm5qjNI-configgen-target/controller-01/horizon/custom_local_settings /tmp/tmp.yJwbxPkga4-configgen-source/controller-01/horizon/custom_local_settings
--- /tmp/tmp.yX2Gm5qjNI-configgen-target/controller-01/horizon/custom_local_settings    2024-04-12 17:27:53.601116706 +0000
+++ /tmp/tmp.yJwbxPkga4-configgen-source/controller-01/horizon/custom_local_settings    2024-04-12 17:27:53.557116710 +0000
@@ -0,0 +1,2 @@
+SESSION_TIMEOUT = 604800
+

@jackhodgkiss jackhodgkiss added the enhancement New feature or request label Apr 12, 2024
@jackhodgkiss jackhodgkiss requested a review from a team as a code owner April 12, 2024 17:38
@markgoddard markgoddard merged commit 37eee88 into main Aug 16, 2024
4 checks passed
@markgoddard markgoddard deleted the config-diff-parallel branch August 16, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants