Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assert that tempest playbook is not executed with a local connection #57

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

markgoddard
Copy link

This playbook copies files to temporary directories. They must be on the
host rather than in the Kayobe container in order to be accessible by the
docker-rally container.

This playbook copies files to temporary directories.  They must be on the
host rather than in the Kayobe container in order to be accessible by the
docker-rally container.
@markgoddard markgoddard requested a review from a team as a code owner May 13, 2024 10:38
@markgoddard markgoddard self-assigned this May 13, 2024
@markgoddard markgoddard requested a review from scrungus May 13, 2024 10:38
@jovial
Copy link
Collaborator

jovial commented Jun 26, 2024

If /tmp was bind mounted into the kayobe container would the local connection plugin work?

@markgoddard
Copy link
Author

Possibly, but it's a bit messy

@jovial
Copy link
Collaborator

jovial commented Jun 26, 2024

Possibly, but it's a bit messy

The only reason I'm hesitant is because I think we might use it like that at one customer. Could we instead try creating a file with docker and seeing if shows up in our /tmp:

           docker run --rm --entrypoint=/usr/bin/bash
           --name tempest
           --network host
           {{ rally_image_full }} touch /tmp/kayobe-automation-run-tempest.yml

Although that might the customer where @scrungus hit this issue.

@markgoddard
Copy link
Author

Possibly, but it's a bit messy

The only reason I'm hesitant is because I think we might use it like that at one customer. Could we instead try creating a file with docker and seeing if shows up in our /tmp:

           docker run --rm --entrypoint=/usr/bin/bash
           --name tempest
           --network host
           {{ rally_image_full }} touch /tmp/kayobe-automation-run-tempest.yml

Although that might the customer where @scrungus hit this issue.

Possibly - my advice was to not use a local connection, and that's why I came up with this change :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants