Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable ironic prometheus exporter deploy and sync #1273

Merged
merged 2 commits into from
Sep 20, 2024
Merged

Disable ironic prometheus exporter deploy and sync #1273

merged 2 commits into from
Sep 20, 2024

Conversation

grzegorzkoper
Copy link
Contributor

@grzegorzkoper grzegorzkoper requested a review from a team as a code owner September 10, 2024 08:17
@Alex-Welsh Alex-Welsh mentioned this pull request Sep 10, 2024
Closed
markgoddard
markgoddard previously requested changes Sep 10, 2024
View reviewed changes
Copy link
Contributor

@markgoddard markgoddard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Release note?

Also the bug says it's fixed.

@grzegorzkoper
Copy link
Contributor Author

@mnasiadka Pointed out that the bug is only partially fixed.
This fix: https://review.opendev.org/c/openstack/kolla-ansible/+/919513 only relates to the bug, not closes it.

Until thats done, we should disable the exporter.

@mnasiadka
Copy link
Member

mnasiadka commented Sep 10, 2024 •
edited
Loading

Release note?

Also the bug says it's fixed.

It's launchpad UI bug, there's only a committed related-bug fix, it's not a final fix - see the attached patches.

@markgoddard
Copy link
Contributor

Release note?
Also the bug says it's fixed.

It's launchpad UI bug, there's only a committed related-bug fix, it's not a final fix - see the attached patches.

Ok. Marked the bug as in progress.

@markgoddard
Copy link
Contributor

Release note?

Also the bug says it's fixed.

Still release note...

@MoteHue
Copy link
Contributor

MoteHue commented Sep 20, 2024

This tripped me up too, so I've taken the liberty of adding the reno. Can we get this merged before any more upgrades start? :)

@MoteHue MoteHue dismissed markgoddard’s stale review September 20, 2024 13:43

dismissed: reno made

@MoteHue MoteHue merged commit e381efb into stackhpc/2024.1 Sep 20, 2024
12 checks passed
@MoteHue MoteHue deleted the disable_ironic_prometheus_exporter branch September 20, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnasiadka mnasiadka mnasiadka approved these changes

@markgoddard markgoddard Awaiting requested review from markgoddard

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@grzegorzkoper @mnasiadka @markgoddard @MoteHue