Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bundler for swift-argument-parser v1.2.4 #33

Merged
merged 2 commits into from
Sep 16, 2023
Merged

Update bundler for swift-argument-parser v1.2.4 #33

merged 2 commits into from
Sep 16, 2023

Conversation

furby-tm
Copy link
Contributor

I had forgotten that the args parser was still pointed at Wabi's fork.

You may pull the latest args parser in from this PR which has your change on top.

Optionally, you may switch the repo to point back to your fork if you do merge it, but I don't mind either way. Though, you may want to set it to the release tag at v1.2.4.

@furby-tm
Copy link
Contributor Author

furby-tm commented Sep 14, 2023

Cleaned up the massive formatting that occurred in the old (closed) PR linked above in favor of this fresh PR: stackotter/swift-arg-parser#2

@furby-tm
Copy link
Contributor Author

furby-tm commented Sep 14, 2023

Slightly annoyingly, if your fork is on a repo called swift-argument-parser, this same-name package dependency will conflict with Apple's inside any transient dependencies that may depend on Apple's swift-argument-parser and can lead to build errors, due to Swift now treating the git repo name as the package name.

A workaround was to change the repo name to anything different, such as swift-arg-parser as I did here, however, since there are other users potentially using older versions of the bundler - it may be best to leave it, and create a additional second fork of it with an altered name.

Though, in either case, you are free to use this fork indefinitely, whatever is easier.

@stackotter
Copy link
Owner

GitHub redirects the old url to the new url indefinitely after renaming a repo, so I think I can safely just rename my fork and not break older versions of bundler 🤞

Copy link
Owner

@stackotter stackotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the swift-argument-parser dependency clash warning once and for all 😅

@stackotter stackotter merged commit 57ca798 into stackotter:main Sep 16, 2023
@stackotter
Copy link
Owner

I've updated bundler to use my fork again now, so feel free to delete your fork if you want 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants