-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a swift bundler command line plugin. #36
Conversation
* This includes the swift bundler as a command line plugin and should transitively become available to all consumers of MetaverseKit, through SwiftUSD. * Await PR to upstream stackotter: stackotter/swift-bundler#36
Awesome, thanks! I was a bit too busy to check it out today, but I’ll have some time tomorrow night |
No worries! It's important to enjoy the holidays too, you know! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just had two questions/suggestions, other than that it looks good to me. Nice and self-contained 👍
Plugins/SwiftBundlerCommandPlugin/SwiftBundlerCommandPlugin.swift
Outdated
Show resolved
Hide resolved
Plugins/SwiftBundlerCommandPlugin/SwiftBundlerCommandPlugin.swift
Outdated
Show resolved
Hide resolved
One small sad note, it appears SwiftPM yeets plugins out of packages that are within other dependencies of your project's dependencies -- not sure if the usage of a commit hash in-place of a release version is somehow causing that behavior or not but I will tag a release on my fork and let you know what happens. Perhaps I'm just abusing SwiftPM with monolithic packages like this, but it seems kind of silly that these things don't transitively come through, given that's how library dependencies work... If this is indeed the case, I will try and see why with one of the SwiftPM project leads.
|
* Note, I have set this to my fork which has an additional fix to TOMLKit - pending a PR. * PR: LebJe/TOMLKit#22
@stackotter Hiya! I'm a big dummy and somehow marked the TOMLKit dependency as However TOMLKit also had an unstable version on one of their dependencies which is pending this PR. Until then, I have set the dependency on my fork if that works for you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm! 🎉 I'm surprised I didn't catch that TOMLKit version issue (branch
instead of from
) when reviewing that previous PR haha, good catch
I'm still in confusion how it worked at all 😆 makes no sense to me, it's got to be the SwiftPM cache or something |
Yeah hahah, probably |
This revision introduces a swift package plugin product for swift bundler, in the form of a command line plugin.
Usage: