Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Plurals in XCStrings #44

Merged
merged 3 commits into from
Mar 4, 2024
Merged

Fix Plurals in XCStrings #44

merged 3 commits into from
Mar 4, 2024

Conversation

JoshuaBrest
Copy link
Contributor

There was a problem where plurals returned (null) when used. This fixes that by adding support for NSStringFormatValueTypeKey.

The code here is really crappy and botched, but it works.

@JoshuaBrest JoshuaBrest changed the title Fix Plurals Fix Plurals in XCStrings Mar 2, 2024
stackotter
stackotter requested changes Mar 3, 2024
View reviewed changes
Copy link
Owner

@stackotter stackotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! Just one tiny formatting change I've requested but other than that it looks pretty good for how gross the file format is lol.

stackotter
stackotter approved these changes Mar 4, 2024
View reviewed changes
Copy link
Owner

@stackotter stackotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I'll merge now

@stackotter stackotter merged commit 6a051a4 into stackotter:main Mar 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stackotter stackotter stackotter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JoshuaBrest @stackotter