Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support other platform sdks from generated xcode project. #52

Merged
merged 6 commits into from
May 8, 2024

Conversation

furby-tm
Copy link
Contributor

@furby-tm furby-tm commented May 7, 2024

  • Namely, this supports the ability for a user to select iOS, visionOS, and tvOS devices from Xcode's run destinations with Xcode projects generated via swift bundler generate-xcode-project, which would otherwise cause the app to be built for the wrong device, macOS, and be unable to be launched from the user's selected run destination.
  • This also allows calls to swift bundler's --platform switch to be synonymously called with apple platform sdk equivalents.

As an example:

swift bundler run --platform xros

Is now also exactly equivalent to:

swift bundler run --platform visionOS

furby-tm added 3 commits May 6, 2024 20:38
* This also adds support for calling swift bundler's --platform switch with its
  apple equivalent (ex. --platform xros is the same as --platform visionOS.)
Copy link
Owner

@stackotter stackotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you thought you could get away with it...

@furby-tm furby-tm requested a review from stackotter May 7, 2024 05:28
@furby-tm
Copy link
Contributor Author

furby-tm commented May 7, 2024

@stackotter Attempted to run a swiftformat . and got 134 files formatted 😅. Would you like to issue that in your own commit once this is merged in?

Oh gross, I just noticed you are using apple's swift format, I use this one, would just require you to slap in a new .swiftformat file so that the formatter respects your formatting settings.

Copying over your existing settings with a .swiftformat file at the root of your repo with:

--indent 2
--indentcase true

Only changes 94 files (compared to 134) with far less changes.

@furby-tm furby-tm requested a review from stackotter May 7, 2024 19:40
Copy link
Owner

@stackotter stackotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🎉

@stackotter stackotter merged commit 4409bc7 into stackotter:main May 8, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants