Date picker #244
Date picker #244
Conversation
|
The thought just occurred to me to observe NSSystemTimeZoneDidChange to properly redraw views that use |
|
There’s a backend method called setEnvironmentChangeHandler or something like that. That’s where we currently observe system theme changes and would be where timezone observation should live as well. |
|
Right, I'll go see if I can get that to work in UIKitBackend and AppKitBackend first, and then maybe the other backends. I don't think it'll necessarily work on Linux though |
|
Marking this as draft because UIDatePicker (at least on iOS 17) completely misbehaves if the user changes the time zone in settings |
stackotter
left a comment
stackotter
left a comment
There was a problem hiding this comment.
Thanks for this super detailed PR! Safari was lagging the entire time that I was reviewing your changes lol. I've left a bunch of requests and comments from an initial read through of all of the code.
I haven't had time to test out the changes myself yet, but I'll make sure to do that before merging and will update the PR with any additional feedback I have after testing things out.
stackotter
left a comment
stackotter
left a comment
There was a problem hiding this comment.
Now that the DatePicker example is relatively simple, I reckon it could make sense to merge it into ControlsExample.
|
I think I've gone through and closed all of the review comments that have been addressed and commented on ones that I have more questions about. Regarding the GtkBackend TimePicker implementation: when I originally reviewed it I didn't realise that it's unused. If you'd like, feel free to turn my current comments on it into todo comments and document clearly that the class is neither ready nor used, and I'd count those comments as resolved. I more just want to avoid another contributor coming along and trying to use it assuming that it's meant to work properly in its current form. |
stackotter
left a comment
stackotter
left a comment
There was a problem hiding this comment.
Somehow GitHub just had some of these comments pending from a while ago. I guess I must've left the review halfway through?
There's also this comment unresolved from a while ago: #244 (comment) . What do you reckon about that idea?
Looking good now though. Happy to merge once the GDateTime documentation comment is addressed and these changes have been rebased onto main.
Sources/SwiftCrossUI/Views/Modifiers/DatePickerStyleModifier.swift
Outdated
Show resolved
Hide resolved
Add DatePicker for AppKitBackend Add DatePickerExample to macOS CI Fix DatePicker update logic for AppKitBackend Update argument name to match SwiftUI Add more availability annotations Shut up tvOS let me see if the iOS CI will pass please work. Fine, here's your view Initial WinUI implementation Reformat WinUI code Implement minYear/maxYear for DatePicker Improve WinUI sizing code Fix CalendarDatePicker size Minor cleanup Generate GTK classes and improve manual type conversion oops Fix casing of calendar name Saving partial work on GtkBackend More partial work Use Gtk.Calendar Add missing parts to GtkBackend.updateDatePicker Add DatePickerExample to Linux CI Fix one Mac availability error Add availability annotation on unused widget Add time zone listener for UIKitBackend Add listener for AppKitBackend Address some PR comments Update some doc comments Support date-only pickers in AppKitBackend Change default timezone and calendar from autoupdatingCurrent to current Address more PR comments tvOS please compile first try
|
I think you'll have to run |
Done, and added a |
| VStack { | ||
| Text("Selected date: \(date)") | ||
|
|
||
| Picker(of: supportedDatePickerStyles, selection: $datePickerStyle) |
There was a problem hiding this comment.
Please put this in an HStack along with a label (like above for the flavour picker) so that it's clear what the picker is for
|
|
||
| Picker(of: supportedDatePickerStyles, selection: $datePickerStyle) | ||
|
|
||
| DatePicker( |
There was a problem hiding this comment.
Please put the entirety of ControlsExample into a ScrollView because it's gotten pretty tall now (too tall for my laptop display). I probably should've done that a while ago
2 participants
Fixes #233
Each backend has its own shortcomings:
hourMinuteAndSecond, and doesn't respect font colorwheelpicker stylehourMinuteAndSecond, doesn't respect font color, and doesn't respectenvironment.timeZone(instead always using the current time zone)graphicalpicker style, doesn't respectenvironment.timeZone(instead always using UTC), and only supports picking the date, not the time