Skip to content

Fix Gtk3Backend crash with zero-width/zero-height images #309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stackotter merged 2 commits into from
Jan 5, 2026
+10 −0
Merged

Fix Gtk3Backend crash with zero-width/zero-height images #309

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9b4e4c1
fix Gtk3Backend crash with zero-width/zero-height images
kaascevich Jan 5, 2026
1832921
correct comment capitalization
kaascevich Jan 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions Sources/Gtk3/Widgets/Image+ManualAdditions.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
import CGtk3

extension Image {
public func clear() {
gtk_image_clear(castedPointer())
}

public func setPath(_ path: String) {
gtk_image_set_from_file(castedPointer(), path)
}
Expand Down
6 changes: 6 additions & 0 deletions Sources/Gtk3Backend/Gtk3Backend.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -677,6 +677,12 @@ public final class Gtk3Backend: AppBackend {
) {
let imageView = imageView as! Gtk3.Image

// check if the resulting image would be empty
guard targetWidth > 0, targetHeight > 0 else {
imageView.clear()
return
}

let pixbuf = Pixbuf(
rgbaData: rgbaData,
width: width,
Expand Down
Loading