Skip to content

Add a default first menu item implementation. #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stackotter merged 3 commits into from
Jan 9, 2025
Merged

Add a default first menu item implementation. #97

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ea9a8b7
Add first menu item for appkit backend.
furby-tm Jan 4, 2025
f90b3ea
fix package dependencies.
furby-tm Jan 4, 2025
1a71088
Merge branch 'layout_system' into layout_system
stackotter Jan 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Package.resolved
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

29 changes: 24 additions & 5 deletions Sources/AppKitBackend/AppKitBackend.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,11 +154,10 @@ public final class AppKitBackend: AppBackend {
) -> (menuBar: NSMenu, helpMenu: NSMenu?) {
let menuBar = NSMenu()

// The first menu item is special and always takes on the name of the
// app. For now just create a dummy item for it.
let dummy = NSMenuItem()
dummy.submenu = NSMenu()
menuBar.addItem(dummy)
// The first menu item is special and always takes on the name of the app.
let about = NSMenuItem()
about.submenu = createDefaultAboutMenu()
menuBar.addItem(about)

var helpMenu: NSMenu?
for submenu in submenus {
Expand All @@ -173,6 +172,26 @@ public final class AppKitBackend: AppBackend {
return (menuBar, helpMenu)
}

public static func createDefaultAboutMenu() -> NSMenu {
let appName = ProcessInfo.processInfo.processName
let appMenu = NSMenu(title: appName)
appMenu.addItem(withTitle: "About \(appName)", action: #selector(NSApp.orderFrontStandardAboutPanel(_:)), keyEquivalent: "")
appMenu.addItem(NSMenuItem.separator())

let hideMenu = appMenu.addItem(withTitle: "Hide \(appName)", action: #selector(NSApp.hide(_:)), keyEquivalent: "h")
hideMenu.keyEquivalentModifierMask = .command

let hideOthers = appMenu.addItem(withTitle: "Hide Others", action: #selector(NSApp.hideOtherApplications(_:)), keyEquivalent: "h")
hideOthers.keyEquivalentModifierMask = [.option, .command]

appMenu.addItem(withTitle: "Show All", action: #selector(NSApp.unhideAllApplications(_:)), keyEquivalent: "")

let quitMenu = appMenu.addItem(withTitle: "Quit \(appName)", action: #selector(NSApp.terminate(_:)), keyEquivalent: "q")
quitMenu.keyEquivalentModifierMask = .command

return appMenu
}

public func setApplicationMenu(_ submenus: [ResolvedMenu.Submenu]) {
let (menuBar, helpMenu) = Self.renderMenuBar(submenus)
NSApplication.shared.mainMenu = menuBar
Expand Down
Loading