[WIP] Use the new collector internal service #2063
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## mauro/collector-service-use-raii #2063 +/- ##
====================================================================
- Coverage 27.51% 25.81% -1.70%
====================================================================
Files 93 98 +5
Lines 5728 6105 +377
Branches 2534 2726 +192
====================================================================
Hits 1576 1576
- Misses 3485 3862 +377
Partials 667 667
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Molter73
force-pushed
the
mauro/ROX-28526-use-collector-iservice
branch
from
5770ec0 to
a2d44bc
Compare
Molter73
changed the base branch from
master
to
mauro/collector-service-use-raii
Molter73
force-pushed
the
mauro/ROX-28526-use-collector-iservice
branch
from
4a61b27 to
3ce1606
Compare
Molter73
force-pushed
the
mauro/collector-service-use-raii
branch
from
1c58c3c to
98ff9f9
Compare
This change makes it possible to have backwards compatibility with older sensor versions that might no implement the new service.
Molter73
force-pushed
the
mauro/ROX-28526-use-collector-iservice
branch
from
3ce1606 to
169fd82
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A detailed explanation of the changes in your PR.
Feel free to remove this section if it is overkill for your PR, and the title of your PR is sufficiently descriptive.
Checklist
Automated testing
If any of these don't apply, please comment below.
Testing Performed
TODO(replace-me)
Use this space to explain how you tested your PR, or, if you didn't test it, why you did not do so. (Valid reasons include "CI is sufficient" or "No testable changes")
In addition to reviewing your code, reviewers must also review your testing instructions, and make sure they are sufficient.
For more details, ref the Confluence page about this section.