Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(toil): simplify Argo deployment and debuggability #1503

Merged
merged 7 commits into from
Mar 5, 2025

Conversation

tommartensen
Copy link
Contributor

@tommartensen tommartensen commented Mar 4, 2025

  • Moving Argo and Monitoring charts to subcharts of the infra-server. This simplifies the deployment and configuration. Incorporates ROX-20269.
  • Disabling authentication on the Argo server. You can port-forward the UI and inspect workflow runs graphically.
  • Updating both charts / applications to the latest available version. Assuming that our tests have good coverage, green tests will attest that the update is without problems.

@tommartensen tommartensen self-assigned this Mar 4, 2025
@rhacs-bot
Copy link
Contributor

rhacs-bot commented Mar 4, 2025

A single node development cluster (infra-pr-1503) was allocated in production infra for this PR.

CI will attempt to deploy quay.io/rhacs-eng/infra-server:0.10.82-7-g9465f0a514 to it.

🔌 You can connect to this cluster with:

gcloud container clusters get-credentials infra-pr-1503 --zone us-central1-a --project acs-team-temp-dev

🛠️ And pull infractl from the deployed dev infra-server with:

nohup kubectl -n infra port-forward svc/infra-server-service 8443:8443 &
make pull-infractl-from-dev-server

🚲 You can then use the dev infra instance e.g.:

bin/infractl -k -e localhost:8443 whoami

⚠️ Any clusters that you start using your dev infra instance should have a lifespan shorter then the development cluster instance. Otherwise they will not be destroyed when the dev infra instance ceases to exist when the development cluster is deleted. ⚠️

Further Development

☕ If you make changes, you can commit and push and CI will take care of updating the development cluster.

🚀 If you only modify configuration (chart/infra-server/configuration) or templates (chart/infra-server/{static,templates}), you can get a faster update with:

make helm-deploy

Logs

Logs for the development infra depending on your @redhat.com authuser:

Or:

kubectl -n infra logs -l app=infra-server --tail=1 -f

Copy link
Contributor

@davdhacs davdhacs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
(and I'm happy to re-review if more changes go into this)

@tommartensen tommartensen force-pushed the tm/argo-workflow-fix-ups branch from 291032a to cb7f7b5 Compare March 5, 2025 07:17
@tommartensen tommartensen changed the title Tm/argo workflow fix ups fix(toil): simplify Argo deployment and debuggability Mar 5, 2025
@tommartensen tommartensen requested a review from davdhacs March 5, 2025 10:02
@tommartensen tommartensen marked this pull request as ready for review March 5, 2025 10:02
@tommartensen tommartensen requested a review from a team as a code owner March 5, 2025 10:02
@tommartensen tommartensen enabled auto-merge (squash) March 5, 2025 10:03
@tommartensen
Copy link
Contributor Author

I intend to deploy a new version of infra (including all Hackathon changes) after this PR has merged.

https://dev.infra.rox.systems/ is already on a version with the new UI.

@tommartensen tommartensen merged commit 998d003 into master Mar 5, 2025
10 checks passed
@tommartensen tommartensen deleted the tm/argo-workflow-fix-ups branch March 5, 2025 10:28
@davdhacs
Copy link
Contributor

davdhacs commented Mar 6, 2025

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants