Skip to content

Conversation

@mtodor
Copy link
Collaborator

@mtodor mtodor commented Dec 16, 2025

Description

This PR is adding fetching of clusters affected by a CVE.

Validation

  • Unit tests
  • Tested with LLM

Testing example

Prompt: Is this CVE affecting me RHSA-2024:6412?
LLM called all 3 tools and responded:

  - Clusters affected: 1 cluster
    - staging-secured-cluster
  - Deployments affected: None
  - Nodes affected: 6 nodes

Prompt: Is affected by CVE-2021-12345?
LLM: didn't call get clusters by CVE tool

Prompt: (cluster does not exist) Is dev-infra-cluster affected by CVE-2021-12345?
LLM called all 3 tools without cluster filter and responded:

CVE-2021-12345 is not affecting any clusters, deployments, or nodes in your entire infrastructure, including dev-infra-cluster.

@codecov-commenter
Copy link

codecov-commenter commented Dec 16, 2025

Codecov Report

❌ Patch coverage is 92.18750% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.78%. Comparing base (8c77a67) to head (a2fdc52).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
internal/toolsets/vulnerability/clusters.go 91.66% 3 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #20      +/-   ##
==========================================
+ Coverage   85.38%   85.78%   +0.40%     
==========================================
  Files          24       25       +1     
  Lines         903      964      +61     
==========================================
+ Hits          771      827      +56     
- Misses        101      104       +3     
- Partials       31       33       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mtodor mtodor force-pushed the mtodor/ROX-31479-add-get-nodes-for-cve branch from f3e25c2 to 434f67d Compare December 17, 2025 16:31
@mtodor mtodor force-pushed the mtodor/ROX-31479-add-get-clusters-for-cve branch 2 times, most recently from 660d21a to fc1e150 Compare December 18, 2025 13:38
@mtodor mtodor marked this pull request as ready for review December 18, 2025 13:49
@mtodor mtodor requested a review from janisz as a code owner December 18, 2025 13:49
Base automatically changed from mtodor/ROX-31479-add-get-nodes-for-cve to main December 19, 2025 09:52
@mtodor mtodor force-pushed the mtodor/ROX-31479-add-get-clusters-for-cve branch from fc1e150 to a2fdc52 Compare December 19, 2025 09:53
@mtodor mtodor merged commit 8000112 into main Dec 19, 2025
3 checks passed
@mtodor mtodor deleted the mtodor/ROX-31479-add-get-clusters-for-cve branch December 19, 2025 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants