Skip to content

Conversation

@mtodor
Copy link
Collaborator

@mtodor mtodor commented Dec 17, 2025

Description

This PR is adding affected images to deployments.

For each deployment we will try to fetch affected images by specific CVE. In order to avoid making stress with many requests to central, number of parallel requests is limited to 10.

Validation

  • Unit tests added
  • Testing with LLM
  • Performance difference test

LLM tests

(already had conversation to fetch affected deployments - they have been without images)
Prompt: Can you list images for affected deployments?
Response:

⏺ Here are the affected images for each deployment:

  <Cluster Name>

  1. visa-processor (namespace: payments)
    - quay.io/rhacs-demo/visa-processor:latest-v2
  2. backend-atlas (namespace: backend)
    - quay.io/rhacs-demo/backend-atlas:latest
  3. asset-cache (namespace: frontend)
    - quay.io/rhacs-demo/asset-cache:latest

Performance comparison (on local machine)

  • Only deployments ~280ms
  • Deployments with images ~1660ms
Screenshot 2025-12-18 at 15 56 05

@mtodor mtodor force-pushed the mtodor/ROX-31479-add-get-clusters-for-cve branch from 660d21a to fc1e150 Compare December 18, 2025 13:38
@mtodor mtodor force-pushed the mtodor/ROX-31479-add-fetching-of-images-for-deployments branch 2 times, most recently from 70c8e5f to dcd78bd Compare December 18, 2025 14:46
@codecov-commenter
Copy link

codecov-commenter commented Dec 18, 2025

Codecov Report

❌ Patch coverage is 85.36585% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.71%. Comparing base (8000112) to head (7dffb8b).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
internal/toolsets/vulnerability/tools.go 85.36% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #21      +/-   ##
==========================================
- Coverage   85.78%   85.71%   -0.08%     
==========================================
  Files          25       25              
  Lines         964     1001      +37     
==========================================
+ Hits          827      858      +31     
- Misses        104      108       +4     
- Partials       33       35       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mtodor mtodor marked this pull request as ready for review December 18, 2025 14:51
@mtodor mtodor requested a review from janisz as a code owner December 18, 2025 14:51
@mtodor mtodor force-pushed the mtodor/ROX-31479-add-get-clusters-for-cve branch from fc1e150 to a2fdc52 Compare December 19, 2025 09:53
Base automatically changed from mtodor/ROX-31479-add-get-clusters-for-cve to main December 19, 2025 10:04
@mtodor mtodor force-pushed the mtodor/ROX-31479-add-fetching-of-images-for-deployments branch from dcd78bd to 7dffb8b Compare December 19, 2025 10:06
@mtodor mtodor merged commit abad95f into main Dec 19, 2025
3 of 4 checks passed
@mtodor mtodor deleted the mtodor/ROX-31479-add-fetching-of-images-for-deployments branch December 19, 2025 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants