-
Notifications
You must be signed in to change notification settings - Fork 0
ROX-31479: Add fetching of images for deployments #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mtodor
merged 1 commit into
main
from
mtodor/ROX-31479-add-fetching-of-images-for-deployments
Dec 19, 2025
Merged
ROX-31479: Add fetching of images for deployments #21
mtodor
merged 1 commit into
main
from
mtodor/ROX-31479-add-fetching-of-images-for-deployments
Dec 19, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
660d21a to
fc1e150
Compare
mtodor
commented
Dec 18, 2025
70c8e5f to
dcd78bd
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #21 +/- ##
==========================================
- Coverage 85.78% 85.71% -0.08%
==========================================
Files 25 25
Lines 964 1001 +37
==========================================
+ Hits 827 858 +31
- Misses 104 108 +4
- Partials 33 35 +2 ☔ View full report in Codecov by Sentry. |
janisz
reviewed
Dec 18, 2025
janisz
reviewed
Dec 18, 2025
janisz
reviewed
Dec 18, 2025
janisz
approved these changes
Dec 18, 2025
fc1e150 to
a2fdc52
Compare
Base automatically changed from
mtodor/ROX-31479-add-get-clusters-for-cve
to
main
December 19, 2025 10:04
dcd78bd to
7dffb8b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is adding affected images to deployments.
For each deployment we will try to fetch affected images by specific CVE. In order to avoid making stress with many requests to central, number of parallel requests is limited to 10.
Validation
LLM tests
(already had conversation to fetch affected deployments - they have been without images)
Prompt:
Can you list images for affected deployments?Response:
Performance comparison (on local machine)