fix(qa): cleanup SecretService

[janisz]

Description

This PR uses @Retry annotation to cleanup SecretService.
Instead of returning false/null let's throw an exception and have explicit failure when secret could not be created.

• CHANGELOG update is not needed
• Documentation is not needed

Testing

• inspected CI results

Automated testing

• modified existing tests
• contributed no automated tests

How I validated my change

CI

[janisz]

This change is part of the following stack:

• ROX-28100: retry grpc call #14624
  • fix(qa): cleanup SecretService #14657 ◀

_{Change managed by git-spice.}

[rhacs-bot]

Images are ready for the commit at b5afab4.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.8.x-261-gb5afab4d5a.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.16%. Comparing base (942fc4c) to head (b5afab4).

Additional details and impacted files

@@                    Coverage Diff                     @@
##           rox-28100-retry-grpc-call   #14657   +/-   ##
==========================================================
  Coverage                      49.16%   49.16%           
==========================================================
  Files                           2532     2532           
  Lines                         185503   185548   +45     
==========================================================
+ Hits                           91203    91228   +25     
- Misses                         87069    87082   +13     
- Partials                        7231     7238    +7     

Flag	Coverage Δ
go-unit-tests	49.16% <ø> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[porridge]

1. I'm assuming @Retry has some built-in sleep and appropriate logging?
2. Why are we bothering with making these tests nicer if there is now an officially blessed goal of migrating away from groovy?

[janisz]

1. Correct evaluateWitRetry logs failures

   stackrox/qa-tests-backend/src/main/groovy/util/Helpers.groovy

   Line 29 in d124712

   log.debug("Caught exception. Retrying in ${pauseSecs}s (attempt ${i} of ${retries}): " + t)

2. I did it because you asked chore(qa): compile static on services #14620 (comment)