Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature]: Validation checks withdrawal amounts against rolling cap #1500

Closed
1 task
djordon opened this issue Mar 11, 2025 · 0 comments · Fixed by #1515
Closed
1 task

[Feature]: Validation checks withdrawal amounts against rolling cap #1500

djordon opened this issue Mar 11, 2025 · 0 comments · Fixed by #1515
Assignees
@djordon
Labels
sbtc signer binary The sBTC Bootstrap Signer. withdrawal The withdrawal sBTC operation.
Milestone
sBTC: Withdrawal ...

Comments

@djordon
Copy link
Contributor

djordon commented Mar 11, 2025

Feature - Validation checks withdrawal amounts against rolling cap

1. Description

We need to make sure that pre-sign request validation of withdrawal requests checks the amount against the rolling window.

1.1 Context & Purpose

This is to enforce that the coordinator is respecting the withdrawal amount caps.

2. Technical Details:

2.1 Acceptance Criteria:

  • The pre-sign validation checks include the amount checks for the rolling window.

3. Related Issues and Pull Requests (optional):
@djordon djordon self-assigned this Mar 11, 2025
@djordon djordon added sbtc signer binary The sBTC Bootstrap Signer. withdrawal The withdrawal sBTC operation. labels Mar 11, 2025
@djordon djordon added this to sBTC Mar 11, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in sBTC Mar 11, 2025
@djordon djordon moved this from Needs Triage to Todo in sBTC Mar 11, 2025
@djordon djordon added this to the sBTC: Withdrawal fine tuning milestone Mar 11, 2025
@djordon djordon moved this from Todo to In Progress in sBTC Mar 12, 2025
@djordon djordon mentioned this issue Mar 14, 2025
Merged
1 task
@djordon djordon moved this from In Progress to In Review in sBTC Mar 17, 2025
github-merge-queue bot pushed a commit that referenced this issue Mar 20, 2025
@djordon
feat: validation checks withdrawal amounts against rolling cap (#1515)
52dff64 
## Description

Closes #1500.

This PR needs to be updated once
#1513 gets merged. Right now
some things are hardcoded or just using the wrong variables when
checking the rolling withdrawal limits.

## Changes

* Make sure that the withdrawal limits get checked as part of the
bitcoin validation logic.


## Testing Information

This could probably benefit from a few more test cases, but I'll do that
once #1513 is merged.

## Checklist:

- [x] I have performed a self-review of my code
@github-project-automation github-project-automation bot moved this from In Review to Done in sBTC Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@djordon djordon

Labels
sbtc signer binary The sBTC Bootstrap Signer. withdrawal The withdrawal sBTC operation.
Projects
sBTC
Status: Done
Milestone
sBTC: Withdrawal fine tuning
Development

Successfully merging a pull request may close this issue.

feat: validation checks withdrawal amounts against rolling cap stacks-network/sbtc
1 participant
@djordon