feat: validation checks withdrawal amounts against rolling cap #1515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swept out over a certain window
amounts [ci skip]
4 tasks
matteojug
reviewed
Mar 18, 2025
matteojug
reviewed
Mar 18, 2025
…ainst-rolling-cap
than max money
matteojug
previously approved these changes
Mar 18, 2025
matteojug
approved these changes
Mar 19, 2025
…ainst-rolling-cap
MCJOHN974
approved these changes
Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #1500.
This PR needs to be updated once #1513 gets merged. Right now some things are hardcoded or just using the wrong variables when checking the rolling withdrawal limits.
Changes
Testing Information
This could probably benefit from a few more test cases, but I'll do that once #1513 is merged.
Checklist: