-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: fall-back to current signer set + threshold from contract for stacks tx validation #1333
Open
cylewitruk
wants to merge
8
commits into
main
Choose a base branch
from
feat/use-contract-current-signer-set-for-stacks-tx-validation
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: fall-back to current signer set + threshold from contract for stacks tx validation #1333
cylewitruk
wants to merge
8
commits into
main
from
feat/use-contract-current-signer-set-for-stacks-tx-validation
+638
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
1 task
@djordon @matteojug do we want this functionality (without #1315, i.e. just the fallback logic)? If so, I can open a new PR with this not based on #1315, otherwise we can close this. |
I think we want something similar to this PR for when we want to onboard a new signer. I would break it up into more targeted PRs though.
I'm not a fan of the changes to the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
key rotation
The functionality to rotate a private key for a signer in sBTC-v1.
sbtc signer binary
The sBTC Bootstrap Signer.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes the tx-signer's
assert_valid_stacks_tx_sign_request()
method to use the current signer set public keys & threshold according to the following rule set.main
, so changes from both PR's are in the diff.With only #1315, we would be unable to submit a rotate-keys contract call if any of the signers were missing the dkg shares entry for the current aggregate key. This PR adds a fallback mechanism for this case.
Changes
StacksInteract
method for retrieving thecurrent-signature-threshold
fromsbtc-registry
.StacksInteract
method for retrieving thecurrent-signing-set
fromsbtc-registry
to return anOption<>
, andNone
if the Stacks node returns a404
.assert_valid_stacks_tx_sign_request()
to use a new methodget_current_signer_set_public_keys_and_threshold()
for retrieving the signer set public keys and signature threshold, which uses the above rule set.Testing Information
StacksInteract
changes.devenv
with a deposit and everything looks good.Checklist: