Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat]: Implement rolling withdrawal window in Emily #1528

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

MCJOHN974
Copy link
Collaborator

@MCJOHN974 MCJOHN974 commented Mar 19, 2025

Description

Closes: #1495

Changes

WIP

I added (at least I think so) bitcoin chain tip and mapping bitcoin height => first stacks block ancored to this bitcoin block height to db. Also, wrote a function which returns total withdrawn amount using this info.

TODO:

  • add everything needed to keep this new tables in db up to date
  • add endpoints to provide results of this function to external consumers
  • fix various bugs and style issues
  • add tests
  • fix some .env files and other things to make this new tables in db work

Testing Information

Checklist:

  • I have performed a self-review of my code
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@MCJOHN974 MCJOHN974 requested a review from djordon March 19, 2025 15:07
@MCJOHN974
Copy link
Collaborator Author

Oookay, now it should be mostly done. There are a lot of small things to fix, but core changes and logic are done I think

@MCJOHN974
Copy link
Collaborator Author

@djordon can you pls take a look and I will start cleanup if it looks okish

@MCJOHN974
Copy link
Collaborator Author

Or maybe @matteojug you have more bandwidth for reviews =)

note: I'm not asking for full review, it is still WIP, just approve that logic is generally ok and I can do some cleanup

@MCJOHN974 MCJOHN974 requested a review from matteojug March 19, 2025 15:53
@MCJOHN974 MCJOHN974 self-assigned this Mar 19, 2025
@MCJOHN974 MCJOHN974 added the emily API that communicates with Signers to trigger sBTC operations. label Mar 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
emily API that communicates with Signers to trigger sBTC operations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Implement rolling withdrawal window in Emily
1 participant