Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: depend on clarity backing store interface #5840

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

chore: depend on clarity backing store interface #5840

wants to merge 4 commits into from

Conversation

bestmike007
Copy link
Contributor

Description

The ClarityTransactionConnection currently depends on WritableMarfStore, which is an implementation of the ClarityBackingStore interface. This PR updates the dependency to reference the interface itself, rather than a specific implementation. This change enables third-party extensions to implement and use custom ClarityBackingStore implementations when creating ClarityTransactionConnection.

Checklist

  • Test coverage for new or modified code paths
  • Changelog is updated
  • Required documentation changes (e.g., docs/rpc/openapi.yaml and rpc-endpoints.md for v2 endpoints, event-dispatcher.md for new events)
  • New clarity functions have corresponding PR in clarity-benchmarking repo
  • New integration test(s) added to bitcoin-tests.yml

@bestmike007 bestmike007 requested a review from a team as a code owner February 17, 2025 13:08
@aldur aldur requested a review from obycode February 17, 2025 16:17
@bestmike007 bestmike007 force-pushed the chore/depend-on-clarity-backing-store-interface branch from d0a112f to d2676c7 Compare February 20, 2025 03:53
@obycode obycode requested a review from jbencin February 20, 2025 13:58
@bestmike007
Copy link
Contributor Author

@kantai

@bestmike007 bestmike007 force-pushed the chore/depend-on-clarity-backing-store-interface branch from d2676c7 to c2fad40 Compare March 4, 2025 16:16
obycode
obycode approved these changes Mar 4, 2025
View reviewed changes
Copy link
Contributor

@obycode obycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this improvement!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@obycode obycode obycode approved these changes

@jbencin jbencin Awaiting requested review from jbencin

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bestmike007 @obycode