Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: issue RBF when burnchain/miner config changed #5924

Merged
merged 6 commits into from
Mar 20, 2025

Conversation

hstove
Copy link
Contributor

@hstove hstove commented Mar 13, 2025

This adds a step in the relayer's initiative method to check for a burnchain or miner config change. If detected, the IssueBlockCommit directive is returned.

@hstove hstove requested a review from a team as a code owner March 13, 2025 23:55
Copy link

codecov bot commented Mar 14, 2025

Codecov Report

Attention: Patch coverage is 95.38462% with 9 lines in your changes missing coverage. Please review.

Project coverage is 83.71%. Comparing base (9937c41) to head (477eae6).
Report is 29 commits behind head on develop.

Files with missing lines Patch % Lines
testnet/stacks-node/src/globals.rs 62.50% 6 Missing ⚠️
...net/stacks-node/src/tests/nakamoto_integrations.rs 98.41% 2 Missing ⚠️
stackslib/src/config/mod.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #5924       +/-   ##
============================================
+ Coverage    68.14%   83.71%   +15.56%     
============================================
  Files          521      521               
  Lines       382814   382987      +173     
  Branches       323      323               
============================================
+ Hits        260884   320611    +59727     
+ Misses      121922    62368    -59554     
  Partials         8        8               
Files with missing lines Coverage Δ
testnet/stacks-node/src/nakamoto_node/relayer.rs 83.66% <100.00%> (+8.99%) ⬆️
testnet/stacks-node/src/run_loop/neon.rs 84.63% <100.00%> (+0.67%) ⬆️
stackslib/src/config/mod.rs 73.57% <0.00%> (+12.49%) ⬆️
...net/stacks-node/src/tests/nakamoto_integrations.rs 91.89% <98.41%> (+9.03%) ⬆️
testnet/stacks-node/src/globals.rs 71.98% <62.50%> (-0.18%) ⬇️

... and 306 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e21c0dd...477eae6. Read the comment docs.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hstove hstove requested review from kantai, obycode and rdeioris March 17, 2025 16:15
@aldur aldur removed request for obycode and rdeioris March 17, 2025 16:15
@hstove hstove requested review from obycode and rdeioris March 17, 2025 16:15
@aldur aldur removed the request for review from rdeioris March 17, 2025 16:15
@hstove hstove requested a review from obycode March 19, 2025 14:32
@hstove
Copy link
Contributor Author

hstove commented Mar 19, 2025

@obycode tagged for re-review when you can! 🙏

@hstove hstove requested a review from kantai March 19, 2025 15:20
Copy link
Contributor

@obycode obycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@obycode obycode added this pull request to the merge queue Mar 20, 2025
Merged via the queue into stacks-network:develop with commit 442519e Mar 20, 2025
188 of 193 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants