Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update contributing.md adding details about a product oriented changelog #5925

Merged
merged 1 commit into from
Mar 20, 2025

Conversation

fdefelici
Copy link

@fdefelici fdefelici commented Mar 14, 2025

Description

This is a proposal to improve the contributing page about what change record can be included in the changelog or not.

Applicable issues

Additional info (benefits, drawbacks, caveats)

Checklist

  • Test coverage for new or modified code paths
  • Changelog is updated
  • Required documentation changes (e.g., docs/rpc/openapi.yaml and rpc-endpoints.md for v2 endpoints, event-dispatcher.md for new events)
  • New clarity functions have corresponding PR in clarity-benchmarking repo
  • New integration test(s) added to bitcoin-tests.yml

@fdefelici fdefelici force-pushed the chore/update-contributing branch from aa0d8a2 to 600f2e1 Compare March 14, 2025 12:01
@fdefelici fdefelici self-assigned this Mar 19, 2025
@fdefelici fdefelici force-pushed the chore/update-contributing branch from 600f2e1 to 815a175 Compare March 19, 2025 12:32
@aldur aldur added this to the 3.1.0.0.8 milestone Mar 19, 2025
@aldur aldur requested review from kantai and wileyj March 19, 2025 15:42
Copy link
Collaborator

@wileyj wileyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wileyj wileyj added this pull request to the merge queue Mar 20, 2025
Merged via the queue into stacks-network:develop with commit f8f19d0 Mar 20, 2025
188 of 192 checks passed
Copy link

codecov bot commented Mar 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.51%. Comparing base (c87ade3) to head (815a175).
Report is 36 commits behind head on develop.

❌ Your project status has failed because the head coverage (78.51%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

❗ There is a different number of reports uploaded between BASE (c87ade3) and HEAD (815a175). Click for more details.

HEAD has 10 uploads less than BASE
Flag BASE (c87ade3) HEAD (815a175)
147 137
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #5925      +/-   ##
===========================================
- Coverage    83.70%   78.51%   -5.19%     
===========================================
  Files          521      521              
  Lines       382773   382815      +42     
  Branches       323      323              
===========================================
- Hits        320381   300566   -19815     
- Misses       62384    82241   +19857     
  Partials         8        8              

see 191 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b875da...815a175. Read the comment docs.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

4 participants