Refactor: use log macros without importing from slog #5944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kantai
force-pushed
the
chore/refactor-log-macros
branch
from
2f35403 to
dec99dc
Compare
fdefelici
reviewed
Mar 21, 2025
| @@ -22,7 +22,6 @@ | |||
| #[macro_use] | |||
| extern crate stacks_common; | |||
|
|
|||
| #[macro_use(slog_debug, slog_info, slog_warn)] | |||
| extern crate slog; | |||
There was a problem hiding this comment.
now that we've removed macro_use, could we also remove extern crate slog right? Or do we keep it for some other reason?
jferrant
approved these changes
Mar 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logging macros previously required that users import both the macro and the corresponding slog macro, which is pretty annoying (and at least in my case, trips up my editor's auto import so that I could auto-import the logging macro, but needed to manually add the slog macro import).