Chore/merge develop to aac client breaking #6618
Merged
+7,516
−2,129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add tests for `secp256k1-verify` and `secp256k1-recover?` while adding tests for this new function.
This removes the need for trying the recovery bytes to find the right one.
…eserialize` The signature will be checked after deserialization. Checking it here will cause a deserialization failure when what we actually want is a signature validation failure.
This check is unnecessary and it can't run in tests, since we sometimes provide fake signatures which will fail. Leaving it in place outside of tests to make sure we don't accidentally change some behavior.
If the body hits a runtime error, that should be passed up before bothering to check the allowances (and the changes should be rolled back).
… into chore/merge-develop-to-aac-client-breaking
Signed-off-by: Jacinta Ferrant <[email protected]>
…cle-length chore: reduce cycle length for AAC tests
federico-stacks
previously approved these changes
Oct 28, 2025
francesco-stacks
previously approved these changes
Oct 28, 2025
These changed for epoch 3.3 because the costs-4 contract changed.
…optests Proptests for Clarity 4 functions
feat: add costs for Clarity 4
… into chore/merge-develop-to-aac-client-breaking
jacinta-stacks
dismissed stale reviews from francesco-stacks and federico-stacks
via
ac55c7b
francesco-stacks
approved these changes
Oct 29, 2025
brice-stacks
approved these changes
Oct 29, 2025
Merged
via the queue into
stacks-network:aac-client-breaking
with commit Oct 29, 2025
d94b35c
601 of 614 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.