Skip to content

Conversation

@jacinta-stacks
Copy link

Replaces #6608

@jacinta-stacks jacinta-stacks force-pushed the feat/expand-consensus-test-to-support-pre-nakamoto-epochs branch from 86e4e60 to 58cee2e Compare October 22, 2025 21:24
@CLAassistant
Copy link

CLAassistant commented Oct 22, 2025

CLA assistant check
All committers have signed the CLA.

@jacinta-stacks jacinta-stacks force-pushed the feat/expand-consensus-test-to-support-pre-nakamoto-epochs branch 5 times, most recently from c3a3c2f to c6ce521 Compare October 22, 2025 23:22
Signed-off-by: Jacinta Ferrant <[email protected]>
@jacinta-stacks jacinta-stacks force-pushed the feat/expand-consensus-test-to-support-pre-nakamoto-epochs branch from c6ce521 to 1eb48de Compare October 27, 2025 16:21
… into feat/expand-consensus-test-to-support-pre-nakamoto-epochs
Signed-off-by: Jacinta Ferrant <[email protected]>
… into feat/expand-consensus-test-to-support-pre-nakamoto-epochs
Signed-off-by: Jacinta Ferrant <[email protected]>
…t to use all epochs GTE epoch 2.0

Signed-off-by: Jacinta Ferrant <[email protected]>
… into feat/expand-consensus-test-to-support-pre-nakamoto-epochs
@jacinta-stacks jacinta-stacks marked this pull request as ready for review October 28, 2025 22:13
@jacinta-stacks jacinta-stacks requested review from a team as code owners October 28, 2025 22:13
@codecov
Copy link

codecov bot commented Oct 29, 2025

Codecov Report

❌ Patch coverage is 80.66743% with 168 lines in your changes missing coverage. Please review.
✅ Project coverage is 68.99%. Comparing base (060b56e) to head (3650058).

Files with missing lines Patch % Lines
stackslib/src/chainstate/tests/mod.rs 67.80% 141 Missing ⚠️
stackslib/src/chainstate/tests/consensus.rs 95.96% 14 Missing ⚠️
stackslib/src/chainstate/coordinator/mod.rs 0.00% 7 Missing ⚠️
stackslib/src/chainstate/nakamoto/tests/node.rs 89.09% 6 Missing ⚠️

❌ Your project check has failed because the head coverage (68.99%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6619      +/-   ##
===========================================
+ Coverage    61.40%   68.99%   +7.59%     
===========================================
  Files          574      574              
  Lines       354916   355501     +585     
===========================================
+ Hits        217939   245284   +27345     
+ Misses      136977   110217   -26760     
Files with missing lines Coverage Δ
stacks-common/src/types/mod.rs 80.66% <ø> (+0.58%) ⬆️
...ackslib/src/chainstate/nakamoto/coordinator/mod.rs 81.76% <100.00%> (-0.62%) ⬇️
stackslib/src/net/tests/mod.rs 53.47% <100.00%> (-0.08%) ⬇️
stackslib/src/chainstate/nakamoto/tests/node.rs 83.95% <89.09%> (+0.39%) ⬆️
stackslib/src/chainstate/coordinator/mod.rs 80.00% <0.00%> (+1.15%) ⬆️
stackslib/src/chainstate/tests/consensus.rs 94.11% <95.96%> (+1.84%) ⬆️
stackslib/src/chainstate/tests/mod.rs 68.31% <67.80%> (-1.77%) ⬇️

... and 328 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 060b56e...3650058. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

@francesco-stacks francesco-stacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still need to finish the review of the changes in the consensus.rs file, but GREAT work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants