Skip to content

Conversation

@brice-stacks
Copy link
Contributor

The confirmations field should be a signed integer, since it goes negative when the transaction is conflicting.

The `confirmations` field should be a signed integer, since it goes
negative when the transaction is conflicting.
@codecov
Copy link

codecov bot commented Dec 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.81%. Comparing base (fdf1041) to head (7c2cf19).
⚠️ Report is 4 commits behind head on develop.

❌ Your project check has failed because the head coverage (72.81%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6749      +/-   ##
===========================================
- Coverage    77.68%   72.81%   -4.88%     
===========================================
  Files          580      580              
  Lines       360194   360229      +35     
===========================================
- Hits        279832   262315   -17517     
- Misses       80362    97914   +17552     
Files with missing lines Coverage Δ
...-node/src/burnchains/rpc/bitcoin_rpc_client/mod.rs 94.16% <ø> (-3.12%) ⬇️

... and 277 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fdf1041...7c2cf19. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

@simone-stacks simone-stacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants