fix: don't resend block acceptance if already sent #6750
+84
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to differentiate between a signer that has sent a pre-commit and that has sent its approval.
Contributor
Author
|
It turns out this is not as simple as I hoped. |
This allows the signer to differentiate between a block that it has pre-committed to and one that it has actually signed. Fixes: stacks-network#6743
brice-stacks
force-pushed
the
fix/avoid-extra-approvals
branch
from
5cddcc4 to
143fa6d
Compare
This just removes an unexpected warn in test logs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The signer is currently sending an approval for every pre-commit that it receives after reaching the threshold weight. This change just makes sure it only sends its approval when it first reaches that threshold, and then ignores the rest of the pre-commits.