Open
Conversation
Author
|
@ianthetechie @Archdoog - not allowed to request reviews yet so requesting via comment 😅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We use insets to "push down" the current location marker to the lower third during navigation, but thats not great while not navigating.
This PR addresses this by only using those insets when navigating, while passing in the parent safe area insets when not.
Before, notice how the dot is centered in the lower third even though we are not navigating.
After it is now centered in the view.
In non navigation states - it respects the safe areas provided by the parent - here a view is placed in the safe area at the bottom, and the puck is now centered in the visible area:
