-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade everything to Swift 5.9 and Sendable correctness, use SwiftHTTPTypes #10
Conversation
…iftHTTPTypes. What a zoo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of comments
Sources/StructuredAPIClient/Handlers/BackgroundTaskHandler.swift
Outdated
Show resolved
Hide resolved
Sources/StructuredAPIClient/Transport/URLSessionTransport.swift
Outdated
Show resolved
Hide resolved
…improve CI. Revise README. Improve behavior of the URLSessionTransport vis a vis locking.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
8347aad
to
ddf0b57
Compare
…n with the wrong answer...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor comment
|
||
StructuredAPIClient is tested on macOS, iOS, tvOS, Linux, and Windows, and is known to support the following operating system versions: | ||
|
||
* Ubuntu 16.04+ | ||
* Ubuntu 18.04+ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does 5.9 even support 18.04? It's EOL so you should probably raise it to 20.04
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch, you're right, 5.9 only goes back to focal.
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
…TPTypes (#10) * Upgrade everything to Swift 5.9 and Sendable correctness, also use SwiftHTTPTypes. What a zoo. * Remove BackgroundTaskHandler entirely. * Heavily improve CI. Revise README. Improve behavior of the URLSessionTransport vis a vis locking. * Create dependabot.yml * Add code coverage uploads, CodeQL scanning, and dependency graph submission
What a zoo.
This was so overarching I did it as a PR.