Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade everything to Swift 5.9 and Sendable correctness, use SwiftHTTPTypes #10

Merged
merged 14 commits into from
Dec 1, 2023

Conversation

gwynne
Copy link
Member

@gwynne gwynne commented Nov 24, 2023

What a zoo.

This was so overarching I did it as a PR.

@gwynne gwynne requested a review from tkrajacic November 24, 2023 15:33
Copy link

@0xTim 0xTim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of comments

Copy link
Contributor

@tkrajacic tkrajacic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gwynne gwynne force-pushed the sendable-overhaul branch from 8347aad to ddf0b57 Compare December 1, 2023 12:48
Copy link

@0xTim 0xTim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment


StructuredAPIClient is tested on macOS, iOS, tvOS, Linux, and Windows, and is known to support the following operating system versions:

* Ubuntu 16.04+
* Ubuntu 18.04+
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does 5.9 even support 18.04? It's EOL so you should probably raise it to 20.04

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, you're right, 5.9 only goes back to focal.

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@gwynne gwynne merged commit 145b8bf into main Dec 1, 2023
10 checks passed
@gwynne gwynne deleted the sendable-overhaul branch December 1, 2023 14:25
gwynne added a commit that referenced this pull request Dec 1, 2023
…TPTypes (#10)

* Upgrade everything to Swift 5.9 and Sendable correctness, also use SwiftHTTPTypes. What a zoo.
* Remove BackgroundTaskHandler entirely.
* Heavily improve CI. Revise README. Improve behavior of the URLSessionTransport vis a vis locking.
* Create dependabot.yml
* Add code coverage uploads, CodeQL scanning, and dependency graph submission
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants