Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lots more cleaning up #11

Merged
merged 4 commits into from
Dec 5, 2023
Merged

Lots more cleaning up #11

merged 4 commits into from
Dec 5, 2023

Conversation

gwynne
Copy link
Member

@gwynne gwynne commented Dec 3, 2023

  • Bump the swift-http-types version requirement
  • Fix a broken link in the README
  • Add a dependency on stairtree/async-helpers
  • Do lots of general cleanup of syntax and formatting
  • Improve documentation comments
  • Use the locking primitives from AsyncHelpers
  • Provide better granularity of request timing when trace logging
  • Remove archaisms around the Concurrency support

@gwynne gwynne requested a review from tkrajacic December 3, 2023 15:15
Copy link

codecov bot commented Dec 3, 2023

Codecov Report

Merging #11 (4b0ccc8) into main (6d3efe8) will increase coverage by 0.49%.
Report is 1 commits behind head on main.
The diff coverage is 49.15%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #11      +/-   ##
==========================================
+ Coverage   57.34%   57.84%   +0.49%     
==========================================
  Files          12       10       -2     
  Lines         211      204       -7     
==========================================
- Hits          121      118       -3     
+ Misses         90       86       -4     
Files Coverage Δ
Sources/StructuredAPIClient/NetworkRequest.swift 0.00% <ø> (ø)
...s/StructuredAPIClientTestSupport/TestRequest.swift 100.00% <100.00%> (ø)
...cturedAPIClientTestSupport/TestTokenProvider.swift 80.00% <ø> (ø)
...StructuredAPIClientTestSupport/TestTransport.swift 89.47% <100.00%> (ø)
...uredAPIClient/Handlers/AddHTTPHeadersHandler.swift 95.00% <66.66%> (-5.00%) ⬇️
...PIClient/Handlers/TokenAuthenticationHandler.swift 72.09% <77.77%> (-3.91%) ⬇️
Sources/StructuredAPIClient/NetworkClient.swift 83.78% <78.26%> (+1.64%) ⬆️
...turedAPIClient/Transport/URLSessionTransport.swift 0.00% <0.00%> (ø)
...rces/StructuredAPIClient/Transport/Transport.swift 40.00% <0.00%> (-40.00%) ⬇️
...ructuredAPIClient/Transport/TransportFailure.swift 0.00% <0.00%> (ø)

Copy link
Contributor

@tkrajacic tkrajacic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@0xTim 0xTim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gwynne gwynne merged commit 003bb94 into main Dec 5, 2023
10 checks passed
@gwynne gwynne deleted the more-cleanup branch December 5, 2023 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants