Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing builder_proposals flag for lighthouse #63

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

matilote
Copy link

builder_proposals should be set to true to enable connection to the builder and querying blind blocks. ref: https://lighthouse-book.sigmaprime.io/builders.html#validator-definitions-example

Signed-off-by: Mateusz Jędrzejewski [email protected]

`builder_proposals` should be set to true to enable connection to the builder and querying blind blocks.
ref: https://lighthouse-book.sigmaprime.io/builders.html#validator-definitions-example

Signed-off-by: Mateusz Jędrzejewski <[email protected]>
Signed-off-by: Mateusz Jędrzejewski <[email protected]>
@matilote matilote marked this pull request as ready for review November 12, 2022 12:40
@antares-sw
Copy link
Contributor

builder_proposals should be set to true to enable connection to the builder and querying blind blocks. ref: https://lighthouse-book.sigmaprime.io/builders.html#validator-definitions-example

Hey @matilote we don't want to hardcode this value, instead we suggest to use extraFlags in our chart https://github.com/stakewise/helm-charts/blob/main/charts/validators/values.yaml#L181-L186 to set additional flags.

@matilote
Copy link
Author

@unxnn tried setting the flag directly, but it didn't enable proposal. Probably, because the file is getting overwritten there https://github.com/stakewise/helm-charts/blob/41ad003686600a6e9fe4efc9a968560ad19b5c5e/charts/validators/templates/statefulset.yaml#L111

@antares-sw
Copy link
Contributor

@unxnn tried setting the flag directly, but it didn't enable proposal. Probably, because the file is getting overwritten there https://github.com/stakewise/helm-charts/blob/41ad003686600a6e9fe4efc9a968560ad19b5c5e/charts/validators/templates/statefulset.yaml#L111

Try to add:

extraFlags:
  lighthouse:
    - --private-tx-proposals

We use it in our setup and everything looks ok:

Nov 15 07:31:36.547 INFO Published validator registrations to the builder network, count: 1, service: preparation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants