Ignore missed validators in exit sig update task (#235)

* Ignore missed validators in exit sig update task Signed-off-by: cyc60 <[email protected]> * Update tests Signed-off-by: cyc60 <[email protected]> --------- Signed-off-by: cyc60 <[email protected]>
stakewise · Nov 17, 2023 · 8510427 · 8510427
1 parent 2bf007f
commit 8510427
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 5 deletions.
diff --git a/src/conftest.py b/src/conftest.py
@@ -269,7 +269,7 @@ def mocked_oracles(
             for i in range(len(_mocked_oracle_committee.oracle_pubkeys))
         ],
         validators_approval_batch_limit=1,
-        validators_exit_rotation_batch_limit=1,
+        validators_exit_rotation_batch_limit=2,
         signature_validity_period=60,
     )
 

diff --git a/src/exits/tasks.py b/src/exits/tasks.py
@@ -114,9 +114,6 @@ async def _update_exit_signatures(
     outdated_indexes: list[int],
 ) -> None:
     """Fetches update signature requests from oracles."""
-    exit_rotation_batch_limit = oracles.validators_exit_rotation_batch_limit
-    outdated_indexes = outdated_indexes[:exit_rotation_batch_limit]
-
     logger.info('Starting exit signature rotation for %d validators', len(outdated_indexes))
     # pylint: disable=duplicate-code
     validators = await get_validator_public_keys(outdated_indexes)
@@ -184,8 +181,12 @@ async def _get_oracles_request(
         deadline=get_current_timestamp() + oracles.signature_validity_period,
     )
     failed_indexes = []
+    exit_rotation_batch_limit = oracles.validators_exit_rotation_batch_limit
 
     for validator_index, public_key in validators.items():
+        if len(request.public_keys) >= exit_rotation_batch_limit:
+            break
+
         if len(keystores) > 0 and public_key in keystores:
             shards = get_exit_signature_shards(
                 validator_index=validator_index,

diff --git a/src/exits/tests/test_tasks.py b/src/exits/tests/test_tasks.py
@@ -85,5 +85,8 @@ async def test_remote_signer(
             )
 
             assert request.vault_address == vault_address
-            assert request.public_keys == list(validators.values())
+            assert (
+                request.public_keys
+                == list(validators.values())[: oracles.validators_exit_rotation_batch_limit]
+            )
             assert request.deadline == deadline