Refactor remote db setup

README.md

@@ -34,7 +34,8 @@ operator will submit a signature update transaction to the Vault.
 
 The oracles periodically submit consensus rewards of all the vaults to the Keeper contract.
 By default, every vault pulls these updates on the user interaction with the vault (deposit, withdraw, etc.), but it
-also can be done by the vault operator by passing the `--harvest-vault` flag to the `start` command.
+also can be done by the vault operator by passing the `--harvest-vault` flag to the `start` command. Harvesting vault
+rewards simplifies calls to the vault contracts, e.g., you don't need to sync rewards before calling deposit.
 
 ## Usage
 

src/commands/create_keys.py

@@ -84,7 +84,7 @@ def create_keys(
     _export_keystores(
         credentials=credentials,
         keystores_dir=keystores_dir,
-        password_file=str(password_file),
+        password_file=password_file,
         per_keystore_password=per_keystore_password,
         pool_size=pool_size,
     )
@@ -130,7 +130,7 @@ def _export_deposit_data_json(
 def _export_keystores(
     credentials: list[Credential],
     keystores_dir: Path,
-    password_file: str,
+    password_file: Path,
     per_keystore_password: bool,
     pool_size: int | None = None,
 ) -> None:

src/commands/create_wallet.py

@@ -40,19 +40,19 @@ def create_wallet(mnemonic: str, vault: HexAddress, data_dir: str) -> None:
     wallet_dir = vault_config.vault_dir / 'wallet'
 
     wallet_dir.mkdir(parents=True, exist_ok=True)
-    address = _generate_encrypted_wallet(mnemonic, str(wallet_dir))
+    address = _generate_encrypted_wallet(mnemonic, wallet_dir)
     click.echo(
         f'Done. '
         f'The wallet and password saved to {greenify(wallet_dir)} directory. '
         f'The wallet address is: {greenify(address)}'
     )
 
 
-def _generate_encrypted_wallet(mnemonic: str, wallet_dir: str) -> ChecksumAddress:
+def _generate_encrypted_wallet(mnemonic: str, wallet_dir: Path) -> ChecksumAddress:
     Account.enable_unaudited_hdwallet_features()
 
     account = Account().from_mnemonic(mnemonic=mnemonic)
-    password = get_or_create_password_file(path.join(wallet_dir, 'password.txt'))
+    password = get_or_create_password_file(wallet_dir / 'password.txt')
     encrypted_data = Account.encrypt(account.key, password=password)
 
     wallet_name = 'wallet.json'

src/commands/init.py

@@ -33,7 +33,7 @@
 @click.option(
     '--vault',
     prompt='Enter your vault address',
-    help='Vault address',
+    help='The vault address.',
     type=str,
     callback=validate_eth_address,
 )

src/commands/recover.py

@@ -268,7 +268,7 @@ async def _generate_keystores(
         password = (
             generate_password()
             if per_keystore_password
-            else get_or_create_password_file(str(password_file))
+            else get_or_create_password_file(password_file)
         )
         credential.save_signing_keystore(password, str(keystores_dir), per_keystore_password)
         click.secho(

src/commands/remote_signer_setup.py

@@ -158,7 +158,7 @@ async def main(remove_existing_keys: bool) -> None:
     )
 
     # Import as keystores to remote signer
-    password = get_or_create_password_file(str(settings.keystores_password_file))
+    password = get_or_create_password_file(settings.keystores_password_file)
     key_share_keystores = []
     for credential in credentials:
         key_share_keystores.append(deepcopy(credential.encrypt_signing_keystore(password=password)))