Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge update-db with remote-signer-setup #176

Closed
wants to merge 24 commits into from
Closed

Merge update-db with remote-signer-setup #176

wants to merge 24 commits into from

Conversation

antares-sw
Copy link
Contributor

No description provided.

@antares-sw antares-sw self-assigned this Sep 22, 2023
cyc60
cyc60 reviewed Sep 24, 2023
View reviewed changes
src/commands/remote_signer_setup.py Outdated Show resolved Hide resolved
src/commands/remote_signer_setup.py Outdated Show resolved Hide resolved
src/commands/remote_signer_setup.py Outdated Show resolved Hide resolved
src/commands/sync_operator.py Outdated Show resolved Hide resolved
src/commands/sync_operator.py Outdated Show resolved Hide resolved
src/commands/sync_operator.py Outdated Show resolved Hide resolved
antares-sw and others added 3 commits September 25, 2023 09:30
@antares-sw @cyc60
Update src/commands/sync_operator.py
baa6533 
Co-authored-by: Alexander Sysoev <[email protected]>
Signed-off-by: antares-sw <[email protected]>
@antares-sw @cyc60
Update src/commands/sync_operator.py
d81bfd5 
Co-authored-by: Alexander Sysoev <[email protected]>
Signed-off-by: antares-sw <[email protected]>
@antares-sw
Fix comments
a77cd86
@antares-sw antares-sw requested a review from cyc60 September 25, 2023 12:35
cyc60
cyc60 reviewed Sep 25, 2023
View reviewed changes
src/commands/remote_signer_setup.py Outdated Show resolved Hide resolved
src/commands/remote_signer_setup.py Outdated Show resolved Hide resolved
src/commands/remote_signer_setup.py Outdated Show resolved Hide resolved
src/commands/remote_signer_setup.py Show resolved Hide resolved
antares-sw and others added 3 commits September 26, 2023 10:10
@antares-sw @cyc60
Update src/commands/remote_signer_setup.py
6cbff20 
Co-authored-by: Alexander Sysoev <[email protected]>
Signed-off-by: antares-sw <[email protected]>
@antares-sw @cyc60
Update src/commands/remote_signer_setup.py
5debfc7 
Co-authored-by: Alexander Sysoev <[email protected]>
Signed-off-by: antares-sw <[email protected]>
@antares-sw @cyc60
Update src/commands/remote_signer_setup.py
5b08dbe 
Co-authored-by: Alexander Sysoev <[email protected]>
Signed-off-by: antares-sw <[email protected]>
tsudmi
tsudmi reviewed Sep 26, 2023
View reviewed changes
src/commands/remote_signer_setup.py Outdated Show resolved Hide resolved
src/commands/remote_signer_setup.py Show resolved Hide resolved
src/commands/remote_signer_setup.py Outdated Show resolved Hide resolved
src/commands/remote_signer_setup.py Outdated Show resolved Hide resolved
src/commands/remote_signer_setup.py Show resolved Hide resolved
src/commands/remote_signer_setup.py Show resolved Hide resolved
antares-sw and others added 3 commits September 26, 2023 10:55
@antares-sw @tsudmi
Update src/commands/remote_signer_setup.py
247f560 
Co-authored-by: Dmitri Tsumak <[email protected]>
Signed-off-by: antares-sw <[email protected]>
@antares-sw @tsudmi
Update src/commands/remote_signer_setup.py
a12dc5a 
Co-authored-by: Dmitri Tsumak <[email protected]>
Signed-off-by: antares-sw <[email protected]>
@antares-sw
Refactor
bef2bab
@antares-sw antares-sw requested review from tsudmi and cyc60 September 26, 2023 09:21
tsudmi
tsudmi reviewed Oct 2, 2023
View reviewed changes
Copy link
Member

@tsudmi tsudmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I run the command with --db-url and --remove-existing-keys. The command will try to upload to DB and remove keys from the web3signer. The remote-existing-keys should also work for the DB.

src/commands/remote_signer_setup.py Outdated Show resolved Hide resolved
src/commands/remote_signer_setup.py Outdated Show resolved Hide resolved
src/commands/remote_signer_setup.py Outdated Show resolved Hide resolved
src/commands/remote_signer_setup.py Outdated Show resolved Hide resolved
src/commands/remote_signer_setup.py Outdated Show resolved Hide resolved
src/commands/remote_signer_setup.py Outdated Show resolved Hide resolved
src/commands/remote_signer_setup.py Outdated Show resolved Hide resolved
src/commands/sync_operator.py Outdated Show resolved Hide resolved
src/commands/sync_operator.py Outdated Show resolved Hide resolved
src/commands/sync_operator.py Outdated Show resolved Hide resolved
@antares-sw antares-sw requested a review from tsudmi October 2, 2023 13:56
antares-sw and others added 8 commits October 2, 2023 17:14
@antares-sw @tsudmi
Update src/commands/sync_operator.py
f394eb0 
Co-authored-by: Dmitri Tsumak <[email protected]>
Signed-off-by: antares-sw <[email protected]>
@antares-sw @tsudmi
Update src/commands/sync_operator.py
8bfa1cc 
Co-authored-by: Dmitri Tsumak <[email protected]>
Signed-off-by: antares-sw <[email protected]>
@antares-sw @tsudmi
Update src/commands/sync_operator.py
ef91faf 
Co-authored-by: Dmitri Tsumak <[email protected]>
Signed-off-by: antares-sw <[email protected]>
@antares-sw @tsudmi
Update src/commands/remote_signer_setup.py
dc59953 
Co-authored-by: Dmitri Tsumak <[email protected]>
Signed-off-by: antares-sw <[email protected]>
@antares-sw
Refactor
68f1acd
@antares-sw
update deps
69e8085
@antares-sw
Fix lock
acc5416
@antares-sw
Merge branch 'master' into update-db
e5f3edf 
Signed-off-by: antares-sw <[email protected]>
cyc60
cyc60 reviewed Oct 10, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@antares-sw antares-sw requested a review from cyc60 October 10, 2023 08:33
@antares-sw antares-sw requested a review from cyc60 October 12, 2023 13:23
@tsudmi tsudmi closed this Oct 16, 2023
@antares-sw antares-sw deleted the update-db branch June 11, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evgeny-stakewise evgeny-stakewise Awaiting requested review from evgeny-stakewise

@tsudmi tsudmi Awaiting requested review from tsudmi

@cyc60 cyc60 Awaiting requested review from cyc60

Assignees

@antares-sw antares-sw

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@antares-sw @cyc60 @tsudmi