Skip to content

Commit

Permalink
chore: code review changes
Browse files Browse the repository at this point in the history
  • Loading branch information
jordan-ae committed Jan 14, 2024
1 parent 408f5db commit 6bf40ed
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 5 deletions.
4 changes: 2 additions & 2 deletions frontend/app/src/components/form/bounty/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -444,7 +444,7 @@ function Form(props: FormProps) {
.map((item: FormField) => (
<Input
{...item}
type={item.name === 'description' ? 'textarea' : item.type}
type={item.type}
key={item.name}
newDesign={item.name === 'description' ? false : true}
values={values}
Expand Down Expand Up @@ -487,7 +487,7 @@ function Form(props: FormProps) {
}
label={
item.name === 'description' && !values.ticket_url
? 'Description'
? 'Description *'
: item.label
}
placeholder={
Expand Down
4 changes: 2 additions & 2 deletions frontend/app/src/components/form/inputs/TextAreaInput.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import type { Props } from './propsType';
import { FieldEnv, FieldTextArea, Note } from './index';

const StyleOnText = {
Description: {
'Description *': {
height: '172px',
width: '292px'
},
Expand Down Expand Up @@ -97,7 +97,7 @@ export default function TextAreaInput({
}}
className={active ? 'euiFormRow_active' : (value ?? '') === '' ? '' : 'euiFormRow_filed'}
border={borderType}
label={labeltext === 'Description' ? `${labeltext} *` : labeltext}
label={label}
height={StyleOnText[label].height}
width={StyleOnText[label].width}
>
Expand Down
1 change: 1 addition & 0 deletions frontend/app/src/components/form/inputs/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,7 @@ export const FieldTextArea = styled(EuiTextArea)<styledProps>`
background: ${(p: any) => p?.color && p.color.pureWhite} !important;
max-width: 900px;
width: 292px;
min-height: 167px;
color: ${(p: any) => p?.color && p.color.pureBlack} !important;
box-shadow: none !important;
line-height: 17.6px;
Expand Down
2 changes: 1 addition & 1 deletion frontend/app/src/components/form/schema.ts
Original file line number Diff line number Diff line change
Expand Up @@ -707,7 +707,7 @@ export const wantedCodingTaskSchema: FormField[] = [
},
{
name: 'description',
label: 'Description',
label: 'Description *',
type: 'textarea'
},
{
Expand Down

0 comments on commit 6bf40ed

Please sign in to comment.