Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use zigbuild to unify the build process of binary files and docker #1093

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

vickunwu
Copy link

This PR does the following things:

  • Split the build matrix from 1 to 3 [linux,macos,windows]
  • Create a multi-stage Dockerfile for build binary files as well as the publishing docker image
  • Improve the cache mechanism with sccache and docker build cache (Speed up the build process)
  • Add 3 comment out targets [arm-unknown-linux-gnueabihf,armv7-unknown-linux-musleabihf,arm-unknown-linux-musleabihf] (Not tested, but successfully compiled)
  • Update foundationdb lib to latest stable version and add an aarch64-apple-darwin variant
  • Add an alpine flavor docker image for musl binary files (tagged with a suffix of -alpine)
  • Reduce the size of generated binary files (Guess it's because the use of zig)
  • Update all actions to the latest stable version

@CLAassistant
Copy link

CLAassistant commented Jan 15, 2025

CLA assistant check
All committers have signed the CLA.

@mdecimus
Copy link
Member

I haven't tested it but it looks great, thanks @vickunwu ! If it's not too much of an ask, would be willing to add SLSA provenance to the builds?

@33KK since you created the current build.yml I'm tagging you in case you have time to review this PR. Thanks.

@vickunwu vickunwu force-pushed the main branch 2 times, most recently from f0f223c to 668b4eb Compare January 16, 2025 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants