Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configuration of reverse proxy on a different host #37

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dexterdy
Copy link

@dexterdy dexterdy commented Oct 20, 2024

After testing many different configurations, I figured out that the reverse proxy on a different host only works if both the IP address as well as the network mask are present in the config, not only one of the two.

This was not clearly mentioned in the docs, so I am making a pull request.

As an aside, the netmask can be figured out from the cidr notation ip address, so I feel like also specifying the netmask separately should not be needed.
Also, may I suggest to always allow the netmask of whatever networks the machine is on by default, so users ony have to specify the ip addresses and not also the netmasks?

Other than that, this looks like a really promising software suite feature-wise, though usability and docs can be improved.

@CLAassistant
Copy link

CLAassistant commented Oct 20, 2024

CLA assistant check
All committers have signed the CLA.

@dexterdy dexterdy changed the title Update proxy-protocol.md for configuration of reverse proxy on a different host configuration of reverse proxy on a different host Oct 20, 2024
@mdecimus
Copy link
Member

both the trusted IP addresses and network masks from which the proxy connections originate

This is incorrect. If you specify a network mask there is no need to specify also an IP address.

@dexterdy
Copy link
Author

Ah, in that case this is a bug, I think, because when I tested that, it did not work. I shall try again to make sure that it is not a fluke

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants