Skip to content

fix: Fillout API CI pagination error, flaky phone validation test#286

Merged
preritdas merged 2 commits intomasterfrom
taran/feb2/ci-fixes
Mar 3, 2026
Merged

fix: Fillout API CI pagination error, flaky phone validation test#286
preritdas merged 2 commits intomasterfrom
taran/feb2/ci-fixes

Conversation

@taran-bains
Copy link
Contributor

Fixed Fillout DNS Validator Pagination Logic

File: real_intent/validate/dns.py

Problem: The DNS validator was failing when paginating through large numbers of submissions. The API was returning a 400 error when the offset exceeded the total number of submissions.

Solution: Implemented proper pagination using the totalResponses field from the Fillout API response instead of relying on error handling. The validator now checks if len(submissions) >= total_responses to determine when to stop paginating.

Fixed Flaky Phone Validator Test

File: tests/test_validation.py

Problem: The test was failing because it assumed "fake" phone numbers (properly formatted but non-existent) would be rejected by the Numverify API. However, Numverify's behavior is unpredictable for properly-formatted numbers.

Solution: Removed the unreliable fake_phones list and assertion. The test now only verifies:

  • Invalid format phones are rejected (local validation - reliable)
  • At least some real phones are validated (API connectivity works)

@augmentcode
Copy link

augmentcode bot commented Feb 2, 2026

🤖 Augment PR Summary

Summary: Fixes Fillout DNS validator pagination and stabilizes the phone validation integration test.

Changes:

  • Update Fillout submissions pagination to stop based on the API-provided totalResponses count.
  • Simplify test_phone_validator_with_real_api by removing assertions about “fake but formatted” numbers and focusing on invalid-format rejection + real-number validation.

Technical Notes: Pagination continues in limit=150 increments until collected responses meet/exceed totalResponses.

🤖 Was this summary useful? React with 👍 or 👎

Copy link

@augmentcode augmentcode bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 2 suggestions posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

@preritdas preritdas merged commit cdd75e0 into master Mar 3, 2026
1 of 2 checks passed
@preritdas preritdas deleted the taran/feb2/ci-fixes branch March 3, 2026 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants