fix: Fillout API CI pagination error, flaky phone validation test#286
Merged
fix: Fillout API CI pagination error, flaky phone validation test#286
Conversation
🤖 Augment PR SummarySummary: Fixes Fillout DNS validator pagination and stabilizes the phone validation integration test. Changes:
Technical Notes: Pagination continues in 🤖 Was this summary useful? React with 👍 or 👎 |
preritdas
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed Fillout DNS Validator Pagination Logic
File: real_intent/validate/dns.py
Problem: The DNS validator was failing when paginating through large numbers of submissions. The API was returning a 400 error when the offset exceeded the total number of submissions.
Solution: Implemented proper pagination using the totalResponses field from the Fillout API response instead of relying on error handling. The validator now checks if len(submissions) >= total_responses to determine when to stop paginating.
Fixed Flaky Phone Validator Test
File: tests/test_validation.py
Problem: The test was failing because it assumed "fake" phone numbers (properly formatted but non-existent) would be rejected by the Numverify API. However, Numverify's behavior is unpredictable for properly-formatted numbers.
Solution: Removed the unreliable fake_phones list and assertion. The test now only verifies: