Skip to content

Skip Fillout DNS validator and Scrapybara tests#288

Merged
preritdas merged 1 commit intomasterfrom
skip-tests
Mar 3, 2026
Merged

Skip Fillout DNS validator and Scrapybara tests#288
preritdas merged 1 commit intomasterfrom
skip-tests

Conversation

@preritdas
Copy link
Member

  • Mark all Fillout DNS validator tests as unconditionally skipped (not currently in use)
  • Mark all Scrapybara tests as skipped (fully deprecated, pending removal)

Pull Request opened by Augment Code with guidance from the PR author

- Mark all Fillout DNS validator tests as skipped (not in use)

- Mark all Scrapybara tests as skipped (fully deprecated, pending removal)
@preritdas preritdas merged commit 2742ce0 into master Mar 3, 2026
2 checks passed
@preritdas preritdas deleted the skip-tests branch March 3, 2026 12:27
@augmentcode
Copy link

augmentcode bot commented Mar 3, 2026

🤖 Augment PR Summary

Summary: This PR disables test coverage for two deprecated/unmaintained integrations (Fillout DNS and Scrapybara).

What changed: Fillout DNS validator tests (including the Mongo-backed DNS test) are now unconditionally skipped instead of env-gated.

Scrapybara event generator tests are all marked skipped and the skip messages updated to reflect full deprecation.

The Scrapybara PDF generation test is also now skipped.

Why: These integrations are not currently in use and are pending removal, so tests no longer depend on external services/keys.

Notes: The underlying validator/generator implementations remain in the codebase; only test execution behavior changes.

🤖 Was this summary useful? React with 👍 or 👎

Copy link

@augmentcode augmentcode bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 1 suggestions posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

not os.getenv("MONGO_CONNECT_STR"),
reason="MongoDB connection string not found",
)
@pytest.mark.skip(reason="Fillout DNS validator not in use")
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test targets MongoDNSValidator, but the skip reason says “Fillout DNS validator not in use”, which is a bit misleading in test reports. Consider updating the skip reason to reference Mongo/DNS validation more generally so it’s clear what’s being skipped.

Severity: low

Fix This in Augment

🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant