Add IPv6 Support #36
Draft
Add IPv6 Support #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merterdemir
reviewed
Sep 3, 2025
packet.go
Outdated
| //expecting ip, port | ||
| input = strings.TrimSuffix(input, "\n") | ||
| s := strings.Split(input,":") | ||
| s := strings.Split(input, ":") |
There was a problem hiding this comment.
This might fail with the IPv6 hosts as they use : character within the address string. I would suggest changing this to:
s := strings.Split(input, ";")
and using ; as the new delimiter (or ,).
There was a problem hiding this comment.
Oh that’s right, good catch. So would it be better to change only the IPv6 delimeter to ; or should we consider letting the ; delimeter work on IPv4 as well? It could be confusing for users to need ; for IPv6 but : for IPv4. Maybe should be a question for the maintainers along with which delimeter character they’d prefer
There was a problem hiding this comment.
I added this change to make sure it works for IPv6 and couple more missing changes on the packet construction routine.
…Pv6 support for the RST firewall rule call
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a few changes to make LZR compatible with IPv6:
ipv6Enabledflag, false by default which enables support for IPv6These changes were made by @merterdemir, @GQW19, and myself.