Skip to content

Remove inspect_history from COPRO #8033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 1, 2025

Conversation

TomeHirata
Copy link
Collaborator

@TomeHirata TomeHirata commented Mar 31, 2025

Remove inspect_history from COPRO optimizer.

Fixes #8026

@okhat
Copy link
Collaborator

okhat commented Mar 31, 2025

Thank you @TomeHirata ! Why would we make inspect_history log? It's a function for printing. No one should use it if they don't want to print. Adding logging will clutter the printing with date and time.

Copy link
Collaborator

@chenmoneygithub chenmoneygithub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

logger.info doesn't work well with colorful printing, and this inspect_history is mostly used for debugging, so as Omar mentioned print is the good fit. For the original issue, I think we can remove the logging completely, and we should ship your faqs.md change!

@TomeHirata
Copy link
Collaborator Author

Hi, @okhat @chenmoneygithub. Understood that format change caused by logging is a concern. The colored logging works fine, but I agree that the date and time are a bit clean.
@okhat Do you also agree that we remove this logging from COPRO completely?

@TomeHirata TomeHirata changed the title Replace print in inspect_history with logging Remove inspect_history from COPRO Apr 1, 2025
@TomeHirata TomeHirata force-pushed the fix/inspect_history branch from bfe1bdb to da2c350 Compare April 1, 2025 01:41
@okhat okhat merged commit 4b52b59 into stanfordnlp:main Apr 1, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] I hope to disable the COPRO log when I use prompt_model
3 participants