Add GRPOConfig for Arbor #8882
Closed
Add GRPOConfig for Arbor #8882
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ziems
requested changes
Oct 1, 2025
| @@ -0,0 +1,138 @@ | |||
| from dataclasses import dataclass, field | |||
There was a problem hiding this comment.
Is it possible for us to make a telepromp/grpo/ directory where we can put grpo.py and grpo_config.py? The GEPA optimizer does this so I think there is already a precedent allowing us to do this.
|
@zhassan223 Great work! Requested some small changes but wonderful progress! |
…ted GRPOConfig for rl multihop notebook
Ziems
reviewed
Oct 2, 2025
Ziems
reviewed
Oct 2, 2025
| " multitask=True,\n", | ||
| " num_dspy_examples_per_grpo_step=4,\n", | ||
| " num_samples_per_input=8,\n", | ||
| " num_rollouts_per_grpo_step=8,#changed from num_generations since that parameter doesn't exist anymore\n", |
Ziems
reviewed
Oct 2, 2025
… backwards compatibility to only use GRPOConfig dataclass
Ziems
reviewed
Oct 6, 2025
Ziems
reviewed
Oct 6, 2025
Ziems
reviewed
Oct 6, 2025
|
@zhassan223 it looks like a few tests failed too, could you take a look? |
Ziems
changed the title
zhassan223
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
new data class for GRPO train_kwargs instead of dictionary. Makes it cleaner and has in-data-class argument checks.