More cleanup

starbeamjs · Nov 2, 2023 · 2feefb6 · 2feefb6
1 parent 9d8a23e
commit 2feefb6
Show file tree

Hide file tree

Showing 37 changed files with 1,066 additions and 898 deletions.
diff --git a/@types/vite-env/package.json b/@types/vite-env/package.json
@@ -21,7 +21,7 @@
   },
   "dependencies": {
     "vite": "^4.4.11",
-    "vitest": "^1.0.0-beta.1"
+    "vitest": "^1.0.0-beta.2"
   },
   "devDependencies": {
     "@starbeam-dev/eslint-plugin": "^1.0.0"

diff --git a/package.json b/package.json
@@ -92,32 +92,32 @@
     "test:workspace:lint": "turbo run lint --output-logs errors-only --log-prefix none",
     "test:workspace:prod": "PROD=1 DEV= vitest --run",
     "test:workspace:specs": "vitest --run",
-    "test:workspace:types": "tsc -b"
+    "test:workspace:types": "tsc -b",
+    "vitest": "vitest --pool forks"
   },
   "dependencies": {
     "@starbeam/core-utils": "workspace:^"
   },
   "devDependencies": {
-    "@edge-runtime/vm": "^3.1.4",
-    "@nrr/pnpm-duplicate-cli": "^0.0.1",
-    "@starbeam-dev/compile": "^1.0.1",
-    "@starbeam-dev/core": "^1.0.0",
-    "@starbeam-dev/eslint-plugin": "^1.0.1",
-    "@types/eslint": "^8.44.4",
-    "@types/node": "^20.8.5",
-    "@vitest/ui": "^1.0.0-beta.1",
-    "eslint": "^8.51.0",
+    "@edge-runtime/vm": "^3.1.6",
+    "@starbeam-dev/compile": "^1.0.2",
+    "@starbeam-dev/core": "^1.0.2",
+    "@starbeam-dev/eslint-plugin": "^1.0.4",
+    "@types/eslint": "^8.44.6",
+    "@types/node": "^20.8.10",
+    "@vitest/ui": "^1.0.0-beta.3",
+    "eslint": "^8.52.0",
     "esno": "^0.17.0",
     "esyes": "^1.0.1",
     "fast-glob": "^3.3.1",
-    "happy-dom": "^12.9.1",
+    "happy-dom": "^12.10.3",
     "jsdom": "^22.1.0",
-    "knip": "^2.33.3",
+    "knip": "^2.38.6",
     "prettier": "^3.0.3",
-    "turbo": "^1.10.15",
+    "turbo": "^1.10.16",
     "typescript": "^5.2.2",
-    "vite": "^4.4.11",
-    "vitest": "^1.0.0-beta.1"
+    "vite": "^4.5.0",
+    "vitest": "^1.0.0-beta.3"
   },
   "license": "MIT",
   "nodemonConfig": {
@@ -143,9 +143,6 @@
       "vite": "$vite",
       "vue": "3.3.4"
     },
-    "patchedDependencies": {
-      "@nrr/[email protected]": "patches/@[email protected]"
-    },
     "peerDependencyRules": {
       "allowAny": [
         "react",

diff --git a/packages/preact/preact-testing-utils/package.json b/packages/preact/preact-testing-utils/package.json
@@ -17,7 +17,7 @@
   },
   "scripts": {
     "test:lint": "eslint . --max-warnings 0",
-    "test:specs": "vitest --run",
+    "test:specs": "vitest --run --pool forks",
     "test:types": "tsc -b"
   },
   "dependencies": {

diff --git a/packages/preact/preact-utils/package.json b/packages/preact/preact-utils/package.json
@@ -21,7 +21,7 @@
   },
   "scripts": {
     "test:lint": "eslint . --max-warnings 0",
-    "test:specs": "vitest --run",
+    "test:specs": "vitest --run --pool forks",
     "test:types": "tsc -b"
   },
   "dependencies": {

diff --git a/packages/preact/preact/package.json b/packages/preact/preact/package.json
@@ -25,7 +25,7 @@
   },
   "scripts": {
     "test:lint": "eslint . --max-warnings 0",
-    "test:specs": "vitest --run",
+    "test:specs": "vitest --run --pool forks",
     "test:types": "tsc -b"
   },
   "dependencies": {

diff --git a/packages/react/react/package.json b/packages/react/react/package.json
@@ -22,7 +22,7 @@
   },
   "scripts": {
     "test:lint": "eslint . --max-warnings 0",
-    "test:specs": "vitest --run",
+    "test:specs": "vitest --run --pool forks",
     "test:types": "tsc -b"
   },
   "dependencies": {

diff --git a/packages/react/use-strict-lifecycle/package.json b/packages/react/use-strict-lifecycle/package.json
@@ -26,7 +26,7 @@
     "doc:readme": "node ./scripts/doc.js README",
     "doc:theory": "node ./scripts/doc.js THEORY",
     "test:lint": "eslint . --max-warnings 0",
-    "test:specs": "vitest --run",
+    "test:specs": "vitest --run --pool forks",
     "test:types": "tsc -b"
   },
   "devDependencies": {

diff --git a/packages/universal/collections/package.json b/packages/universal/collections/package.json
@@ -25,7 +25,7 @@
   },
   "scripts": {
     "test:lint": "eslint . --max-warnings 0",
-    "test:specs": "vitest --run",
+    "test:specs": "vitest --run --pool forks",
     "test:types": "tsc -b"
   },
   "dependencies": {

diff --git a/packages/universal/core-utils/package.json b/packages/universal/core-utils/package.json
@@ -21,7 +21,7 @@
   },
   "scripts": {
     "test:lint": "eslint . --max-warnings 0",
-    "test:specs": "vitest --run",
+    "test:specs": "vitest --run --pool forks",
     "test:types": "tsc -b"
   },
   "dependencies": {},

diff --git a/packages/universal/debug/package.json b/packages/universal/debug/package.json
@@ -30,7 +30,7 @@
   },
   "scripts": {
     "test:lint": "eslint . --max-warnings 0",
-    "test:specs": "vitest --run",
+    "test:specs": "vitest --run --pool forks",
     "test:types": "tsc -b"
   },
   "dependencies": {

diff --git a/packages/universal/reactive/package.json b/packages/universal/reactive/package.json
@@ -21,7 +21,7 @@
   },
   "scripts": {
     "test:lint": "eslint . --max-warnings 0",
-    "test:specs": "vitest --run",
+    "test:specs": "vitest --run --pool forks",
     "test:types": "tsc -b"
   },
   "dependencies": {

diff --git a/packages/universal/renderer/package.json b/packages/universal/renderer/package.json
@@ -21,7 +21,7 @@
   },
   "scripts": {
     "test:lint": "eslint . --max-warnings 0",
-    "test:specs": "vitest --run",
+    "test:specs": "vitest --run --pool forks",
     "test:types": "tsc -b"
   },
   "dependencies": {

diff --git a/packages/universal/resource/package.json b/packages/universal/resource/package.json
@@ -20,7 +20,7 @@
   },
   "scripts": {
     "test:lint": "eslint . --max-warnings 0",
-    "test:specs": "vitest --run",
+    "test:specs": "vitest --run --pool forks",
     "test:types": "tsc -b"
   },
   "dependencies": {

diff --git a/packages/universal/resource/src/sync/high-level.ts b/packages/universal/resource/src/sync/high-level.ts
@@ -32,11 +32,11 @@ export class DefineSync {
   #finalize: Cleanup | undefined;
 
   readonly on = {
-    sync: (handler: SyncHandler) => {
+    sync: (handler: SyncHandler): void => {
       this.#sync = handler;
     },
 
-    finalize: (handler: SyncHandler) => {
+    finalize: (handler: SyncHandler): void => {
       this.#finalize = handler;
     },
   };

diff --git a/packages/universal/resource/tests/package.json b/packages/universal/resource/tests/package.json
@@ -19,7 +19,8 @@
     "@starbeam/resource": "workspace:^",
     "@starbeam/runtime": "workspace:^",
     "@starbeam/shared": "workspace:^",
-    "@starbeam-workspace/test-utils": "workspace:^"
+    "@starbeam-workspace/test-utils": "workspace:^",
+    "inspect-utils": "^1.0.1"
   },
   "devDependencies": {
     "@starbeam-dev/eslint-plugin": "^1.0.0"

diff --git a/packages/universal/resource/tests/resource-list/high-level.spec.ts b/packages/universal/resource/tests/resource-list/high-level.spec.ts
@@ -1,5 +1,5 @@
+/* eslint-disable @typescript-eslint/no-magic-numbers */
 import { reactive } from "@starbeam/collections";
-import { DisplayStruct } from "@starbeam/core-utils";
 import { CachedFormula, Cell } from "@starbeam/reactive";
 import {
   Resource,
@@ -9,6 +9,7 @@ import {
 import { pushingScope } from "@starbeam/runtime";
 import { finalize } from "@starbeam/shared";
 import { describe, expect, test } from "@starbeam-workspace/test-utils";
+import { DisplayStruct } from "inspect-utils";
 
 interface Item {
   id: number;

diff --git a/packages/universal/resource/tests/resource-list/syncing.spec.ts b/packages/universal/resource/tests/resource-list/syncing.spec.ts
@@ -1,8 +1,10 @@
+/* eslint-disable @typescript-eslint/no-magic-numbers */
 import { reactive } from "@starbeam/collections";
 import { CachedFormula, Cell, Marker } from "@starbeam/reactive";
 import { Resource, ResourceList } from "@starbeam/resource";
 import { pushingScope } from "@starbeam/runtime";
 import { finalize } from "@starbeam/shared";
+import { hasLength, verified } from "@starbeam/verify";
 import {
   describe,
   entryPoint,
@@ -44,7 +46,7 @@ describe("a ResourceList's children sync", () => {
     const children = reactive.array([
       { id: "child1", value: Cell(0), invalidateSync: Marker() },
       { id: "child2", value: Cell(0), invalidateSync: Marker() },
-    ] satisfies ChildState[]);
+    ] satisfies [ChildState, ChildState]);
 
     const List = ResourceList(children, {
       key: (item) => item.id,
@@ -111,9 +113,9 @@ describe("a ResourceList's children sync", () => {
     events.expect("child3:cleanup", "child3:finalize");
     current.expect(UNCHANGED);
 
-    const [first, second] = children;
-    children[0] = second!;
-    children[1] = first!;
+    const [first, second] = verified(children, hasLength(2)<ChildState>);
+    children[0] = second;
+    children[1] = first;
 
     current.expect(() => ["child2:0", "child1:1"]);
     events.expect([]);

diff --git a/packages/universal/resource/tests/resource.spec.ts b/packages/universal/resource/tests/resource.spec.ts
@@ -1,3 +1,4 @@
+/* eslint-disable @typescript-eslint/no-magic-numbers */
 import { Cell, Marker } from "@starbeam/reactive";
 import type { ResourceBlueprint, SyncFn, SyncResult } from "@starbeam/resource";
 import { Resource, SyncTo } from "@starbeam/resource";

diff --git a/packages/universal/runtime/package.json b/packages/universal/runtime/package.json
@@ -21,7 +21,7 @@
   },
   "scripts": {
     "test:lint": "eslint . --max-warnings 0",
-    "test:specs": "vitest --run",
+    "test:specs": "vitest --run --pool forks",
     "test:types": "tsc -b"
   },
   "dependencies": {
@@ -36,6 +36,7 @@
   "devDependencies": {
     "@starbeam-dev/compile": "^1.0.0",
     "@starbeam-dev/eslint-plugin": "^1.0.0",
-    "rollup": "^4.0.2"
+    "rollup": "^4.0.2",
+    "vite-env": "^1.0.0"
   }
 }
diff --git a/packages/universal/runtime/tests/lifetime.spec.ts b/packages/universal/runtime/tests/lifetime.spec.ts
@@ -1,3 +1,4 @@
+/* eslint-disable @typescript-eslint/no-magic-numbers */
 import { link } from "@starbeam/runtime";
 import { finalize, onFinalize } from "@starbeam/shared";
 import { describe, expect, test } from "vitest";

diff --git a/packages/universal/runtime/tests/tsconfig.json b/packages/universal/runtime/tests/tsconfig.json
@@ -5,17 +5,10 @@
     "declaration": true,
     "declarationDir": "../../../../dist/types",
     "declarationMap": true,
+    "emitDeclarationOnly": true,
     "jsx": "react-jsx",
     "jsxImportSource": "react",
-    "types": [
-      "../../../env.d.ts",
-      "../../../env.d.ts",
-      "../../../env.d.ts",
-      "../../../env.d.ts",
-      "../../../env.d.ts",
-      "../../../env.d.ts"
-    ],
-    "emitDeclarationOnly": true
+    "types": ["vite-env"]
   },
   "exclude": ["dist/**/*"]
 }
diff --git a/packages/universal/service/package.json b/packages/universal/service/package.json
@@ -20,7 +20,7 @@
   },
   "scripts": {
     "test:lint": "eslint . --max-warnings 0",
-    "test:specs": "vitest --run",
+    "test:specs": "vitest --run --pool forks",
     "test:types": "tsc -b"
   },
   "dependencies": {

diff --git a/packages/universal/shared/package.json b/packages/universal/shared/package.json
@@ -22,7 +22,7 @@
   },
   "scripts": {
     "test:lint": "eslint . --max-warnings 0",
-    "test:specs": "vitest --run",
+    "test:specs": "vitest --run --pool forks",
     "test:types": "tsc -b"
   },
   "devDependencies": {

diff --git a/packages/universal/universal/package.json b/packages/universal/universal/package.json
@@ -21,7 +21,7 @@
   },
   "scripts": {
     "test:lint": "eslint . --max-warnings 0",
-    "test:specs": "vitest --run",
+    "test:specs": "vitest --run --pool forks",
     "test:types": "tsc -b"
   },
   "dependencies": {

diff --git a/packages/universal/verify/package.json b/packages/universal/verify/package.json
@@ -21,7 +21,7 @@
   },
   "scripts": {
     "test:lint": "eslint . --max-warnings 0",
-    "test:specs": "vitest --run",
+    "test:specs": "vitest --run --pool forks",
     "test:types": "tsc -b"
   },
   "dependencies": {

diff --git a/packages/universal/verify/src/assertions/basic.ts b/packages/universal/verify/src/assertions/basic.ts
@@ -90,7 +90,7 @@ expected.associate(
 
 interface HasLength<L extends number> {
   <T>(value: T[]): value is FixedArray<T, L>;
-  <T>(value: readonly T[]): value is ReadonlyFixedArray<T, L>;
+  <T>(value: T[] | readonly T[]): value is ReadonlyFixedArray<T, L>;
 }
 
 export function hasLength<L extends number>(length: L): HasLength<L> {

diff --git a/packages/universal/verify/src/verify.ts b/packages/universal/verify/src/verify.ts
@@ -61,7 +61,7 @@ export function verified<T, U extends T>(
 
 verified.noop = <const T, const U extends T>(
   value: T,
-  _check: (input: T) => input is U,
+  _check: <V extends T>(input: T) => input is U,
   _error?: Expectation<T>,
 ): U => {
   return value as U;

diff --git a/packages/vue/vue-testing-utils/package.json b/packages/vue/vue-testing-utils/package.json
@@ -17,7 +17,7 @@
   },
   "scripts": {
     "test:lint": "eslint . --max-warnings 0",
-    "test:specs": "vitest --run",
+    "test:specs": "vitest --run --pool forks",
     "test:types": "tsc -b"
   },
   "dependencies": {

diff --git a/packages/vue/vue/package.json b/packages/vue/vue/package.json
@@ -25,7 +25,7 @@
   },
   "scripts": {
     "test:lint": "eslint . --max-warnings 0",
-    "test:specs": "vitest --run",
+    "test:specs": "vitest --run --pool forks",
     "test:types": "tsc -b"
   },
   "dependencies": {

diff --git a/packages/x/store/package.json b/packages/x/store/package.json
@@ -22,7 +22,7 @@
   },
   "scripts": {
     "test:lint": "eslint . --max-warnings 0",
-    "test:specs": "vitest --run",
+    "test:specs": "vitest --run --pool forks",
     "test:types": "tsc -b"
   },
   "dependencies": {

diff --git a/packages/x/vanilla/package.json b/packages/x/vanilla/package.json
@@ -22,7 +22,7 @@
   },
   "scripts": {
     "test:lint": "eslint . --max-warnings 0",
-    "test:specs": "vitest --run",
+    "test:specs": "vitest --run --pool forks",
     "test:types": "tsc -b"
   },
   "dependencies": {

diff --git a/patches/@[email protected] b/patches/@[email protected]