improve production build #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@starbeam-dev/[email protected], npm/[email protected] |
patricklx
commented
May 7, 2024
| export function verified(v: unknown): unknown { | ||
| if (import.meta.env.DEV) { | ||
| // eslint-disable-next-line prefer-rest-params | ||
| const [value, check, error] = [...arguments] as Parameters<typeof verified>; |
There was a problem hiding this comment.
this hides extra function params from terser, so terser can optimize the prod build and inline this function.
terser will then replace verified(x) with x
patricklx
force-pushed
the
add-ci-check-for-fobidden-texts
branch
from
88c6055 to
d1bf028
Compare
NullVoxPopuli
merged commit 7099168
into
starbeamjs:add-ci-check-for-fobidden-texts
8 checks passed
NullVoxPopuli
added a commit
that referenced
this pull request
May 8, 2024
* Add CI check for forbidden texts * wip * Try this * I think the custom externals stuff has a bug * it worked? * Update workspace/scripts/build-verify.js Co-authored-by: Patrick Pircher <[email protected]> * try this * improve production build (#158) * improve verify * fix preact * fix collections * dont check debug & verify packages * wip * fix reactive * fix lint * improve build * fix type & lint * more lint fixes * fix lint * update @starbeam-dev/eslint-plugin --------- Co-authored-by: Patrick Pircher <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
terser will ofter not optimize const vars. even if they reference noop funcs