Improve git dir detection#36
Open
jpo-joyent wants to merge 1 commit intostarcraftman:masterfrom
jpo-joyent:git-dir-detection
Open
Improve git dir detection#36jpo-joyent wants to merge 1 commit intostarcraftman:masterfrom jpo-joyent:git-dir-detection
jpo-joyent wants to merge 1 commit intostarcraftman:masterfrom
jpo-joyent:git-dir-detection
Conversation
Before this change, when `cd`ing into a .git directory, you would see
the following on every prompt:
git_super_status:[:18: integer expression expected: work
git_super_status:[:28: integer expression expected: operation
git_super_status:[:28: integer expression expected: this
git_super_status:[:31: integer expression expected: operation
git_super_status:[:34: integer expression expected: this
git_super_status:[:40: integer expression expected: must
git_super_status:[:44: integer expression expected: be
git_super_status:[:48: integer expression expected: run
git_super_status:[:52: integer expression expected: in
git_super_status:[:56: integer expression expected: a
After this change, the python script is only run iff git status returns
zero, and stderr is discarded.
This also has the nice side-effect of speeding up prompts while `cd`ing
between dirs that are not in a git repo.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this change, when
cding into a .git directory, you would seethe following on every prompt:
After this change, the python script is only run iff git status returns
zero, and stderr is discarded.
This also has the nice side-effect of speeding up prompts while
cdingbetween dirs that are not in a git repo.