Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to basic ingress controller #80

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

marlonabarua
Copy link

Ingress controller support for the stardog helm chart. (Issue #79)

@marlonabarua marlonabarua requested review from igable and pdmars July 27, 2022 22:21
@marlonabarua marlonabarua removed the request for review from pdmars July 28, 2022 15:07
@marlonabarua marlonabarua removed their assignment Jul 28, 2022
Ingress controller support for the stardog helm chart. (Issue #79)
@marlonabarua marlonabarua force-pushed the feature/issue-79-basic-ingress-support branch from 4dc4b16 to fe2e2bf Compare August 24, 2022 17:08
@marlonabarua marlonabarua assigned ctffarley and igable and unassigned igable Mar 22, 2023
@scardena
Copy link
Contributor

I haven't reviewd in fully yet, as I am waiting for tests to be written for this. Ideally we want to have a cluster up with the basic ingress working.
One question I would ask is, why are you using $variables in this case? why not just pass the actual value right away? for example instead of doing:

{{- $fullName := include "stardog.fullname" . -}}

and then

metadata:
  name: {{ $fullName }}-ingress

I would just do:

metadata:
  name: {{ include "stardog.fullname" . }}-ingress

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants