[VET-4697] remove unused fields #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anneeb
force-pushed
the
remove-unused-sdk-fields
branch
from
76caf3a to
fb47ec6
Compare
|
@paulplace when you have a chance, can you let me know if this contract looks ok for your Portal work? or at least if there's anything included/not included that raises concern on your end. |
|
@anneeb is this still a change you want to commit, or has its time passed? |
|
yes! we still plan on doing it, tracking in https://stardog.atlassian.net/browse/VET-4706 but have been moving it over for other things recently. if you need it sooner for the web cloud stuff, let me know and we can pull it up sooner |
|
There's no rush. I just wanted to make sure this PR is still relevant. |
anneeb
force-pushed
the
remove-unused-sdk-fields
branch
from
7f2baf0 to
37dc4fc
Compare
anneeb
requested review from
joshhk72,
mysticfalconvt and
SpiralP
as code owners
mysticfalconvt
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VET-4697