Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Declaring a smart contract" refactor #1416

Merged
merged 7 commits into from
Nov 19, 2024
Merged

"Declaring a smart contract" refactor #1416

merged 7 commits into from
Nov 19, 2024

Conversation

LandauRaz
Copy link
Collaborator

@LandauRaz LandauRaz commented Nov 19, 2024

Description of the Changes

Refactored "Declaring a smart contract", also addressing #1359 and #1406.

PR Preview URL

https://starknet-io.github.io/starknet-docs/pr-1416/quick-start/declare-a-smart-contract/

Check List

  • Changes made against main branch and PR does not conflict
  • PR title is meaningful, e.g: fix: minor typos in README
  • Detailed description added under "Description of the Changes"
  • Specific URL(s) added under "PR Preview URL"

@starknet-bot
Copy link
Collaborator

Oops, your pull request failed to pass the Typo tests stage :( . see the result:
error: possiblly should be possibly
--> ./components/Starknet/modules/quick-start/pages/declare-a-smart-contract.adoc:89:179
|
89 | In order to interact with Starknet, Starkli requires an RPC endpoint to be configured. For interactions with Starknet Sepolia and Starknet mainnet, Starkli supports default (and possiblly limitied) RPC endpoints when using the --network flag. Configuring a custom RPC endpoint can be done by either using Starkli's --rpc flag or setting up Starkli's STARKNET_RPC enviorment variable. To review all Starknet RPC providers, see the xref:tools:api-services.adoc[API providers section].
| ^^^^^^^^^
|
error: limitied should be limited
--> ./components/Starknet/modules/quick-start/pages/declare-a-smart-contract.adoc:89:189
|
89 | In order to interact with Starknet, Starkli requires an RPC endpoint to be configured. For interactions with Starknet Sepolia and Starknet mainnet, Starkli supports default (and possiblly limitied) RPC endpoints when using the --network flag. Configuring a custom RPC endpoint can be done by either using Starkli's --rpc flag or setting up Starkli's STARKNET_RPC enviorment variable. To review all Starknet RPC providers, see the xref:tools:api-services.adoc[API providers section].
| ^^^^^^^^
|
error: enviorment should be environment
--> ./components/Starknet/modules/quick-start/pages/declare-a-smart-contract.adoc:89:370
|
89 | In order to interact with Starknet, Starkli requires an RPC endpoint to be configured. For interactions with Starknet Sepolia and Starknet mainnet, Starkli supports default (and possiblly limitied) RPC endpoints when using the --network flag. Configuring a custom RPC endpoint can be done by either using Starkli's --rpc flag or setting up Starkli's STARKNET_RPC enviorment variable. To review all Starknet RPC providers, see the xref:tools:api-services.adoc[API providers section].
| ^^^^^^^^^^
|

Please fix the typo, commit and push!

@starknet-bot
Copy link
Collaborator

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-1416/ .

@starknet-bot
Copy link
Collaborator

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-1416/ .

@starknet-bot
Copy link
Collaborator

Oops, your pull request failed to pass the Typo tests stage :( . see the result:
error: necesary should be necessary
--> ./components/Starknet/modules/quick-start/pages/declare-a-smart-contract.adoc:7:44
|
7 | This page will guide you through the steps necesary to declare a smart contract on Starknet. For more details on declaration and its benefits, see xref:architecture-and-concepts:smart-contracts/contract-classes.adoc[Contract classes and instances].
| ^^^^^^^^
|
error: declated should be declared
--> ./components/Starknet/modules/quick-start/pages/declare-a-smart-contract.adoc:162:55
|
162 | In both cases, however, you should be able to see the declated contract on a block explorer like https://sepolia.starkscan.co/[StarkScan] or https://sepolia.voyager.online/[Voyager] by searching for its class hash.
| ^^^^^^^^
|

Please fix the typo, commit and push!

@starknet-bot
Copy link
Collaborator

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-1416/ .

@LandauRaz LandauRaz merged commit 149b179 into main Nov 19, 2024
1 check passed
@LandauRaz LandauRaz deleted the pr-1406 branch November 19, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants