-
Notifications
You must be signed in to change notification settings - Fork 757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test RPC default Providers Services #1061
base: develop
Are you sure you want to change the base?
Conversation
There are 42 commits, with 36 files impacted! |
6aa30bb
to
18dcd3e
Compare
Object.keys(constants.RPC_NODES).map(async (network: any) => { | ||
return Promise.all( | ||
constants.RPC_NODES[network as keyof typeof constants.RPC_NODES].map(async (it: any) => { | ||
const provider = new Provider({ nodeUrl: getBaseUrl(it) }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
except for getBaseUrl(it)
the test here and above are the same, so we can extract it maybe and send as param!
I agree... also am curious for more thoughts! |
I think it's a good idea. Might be worth considering doing this as a separate script since it would bypass the environment setup for the regular tests. |
Just for information, Blast is responding to |
I understand that you want to check if all default networks (list hard coded in the project) are really using default_url_version. Lines 75 to 82 in b3a2946
Logically, it should be OK by definition, but it's never bad to verify. But I don't understand why you want to check the rpc versions of the base urls ... as we are not using them. |
This will be probably revised and done through CI |
Motivation and Resolution
This issue #1058 motivated me to add a test for the default RPC version defined by lib and the default RPC version server by RPC.
This test does not ensure any security just print results.
Could we maybe add some CI warning or action for testing RPC versions?
We could set expectations in this two tests like
Some feedback @ivpavici @penovicp
RPC version (if applicable)
Ensure and Test RPC Providers
Checklist: